Draft
[AppService] Fix appservice plan create Windows examples to include --is-linux false#33828
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
microsoft-github-policy-service
Bot
added
Auto-Assign
Copilot
AI
changed the title
[WIP] Fix appservice plan create examples to reflect correct default OS
[AppService] Fix appservice plan create Windows examples to include --is-linux false
Aug 1, 2026
Collaborator
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
Live test results —
|
![azure-client-tools-agent[bot]](https://avatars.githubusercontent.com/in/4205534?s=60&v=4){kind=small}
There was a problem hiding this comment.
CI Failure Summary
The following checks failed on the latest commit and need to be fixed:
Azure.azure-cli(Build #20260801.6) — the main Azure DevOps build/test pipeline failed. Please check the pipeline logs at https://github.com/Azure/azure-cli/runs/91306318304 and fix the underlying build/test failure.Azure.azure-cli (Check the Format of Pull Request Title and Content)— the PR title does not match the required format for this repo. See details: https://github.com/Azure/azure-cli/runs/91302005949
Use this EXACT PR title (copy verbatim, do not reword):
[AppService] Fix #33821: `az appservice plan create`: Fix Windows plan help examples to include --is-linux false
PR title & description format (required)
This repo enforces a PR format (guide). Please author the PR exactly as follows or CI's Check the Format of Pull Request Title and Content will fail.
Use this EXACT PR title (copy verbatim, do not reword):
[AppService] Fix #33821: `az appservice plan create`: Fix Windows plan help examples to include --is-linux false
Keep the backticks around the command and the Fix #33821: prefix. You may only adjust the wording after the command (the final summary) if the fix changes; the [AppService] prefix, issue link, and backticked command must stay.
Description — follow the PR template and fill in:
- Link the issue — start the Description with a closing keyword so the PR auto-links and closes it:
Fixes #33821. - Related command — the
az ...command this affects. - Description (mandatory) — why the bug happens, what you changed, and the resulting behavior.
- Testing Guide — example command(s) showing the fix works.
- History Notes — leave the title to drive the history note, or add extra lines in the same format (component in brackets + the command in backticks), e.g.
[AppService] `az <command>`: <note>. - Keep the template checklist and tick the items you've satisfied.
Please update the PR title to match exactly, and fix the failing build/tests, then push a new commit.
Posted by agent-assist (autonomous bug-fix pipeline).
Member
|
@copilot the automated CI and live-test review on this PR found failures. Please look into the requested changes here: #33828 (review) and push a fix. Posted by agent-assist (autonomous bug-fix pipeline). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 PR Validation — ️✔️ All clear
Related command
az appservice plan createDescription
az appservice plan createdefaults to Linux when--is-linuxis omitted (introduced in #33395), but the help examples for "Create a Windows app service plan" omitted--is-linux false— silently creating Linux plans for users following the examples. Since an existing plan cannot be converted between OS types, this is a silent destructive mismatch.Fix: Update the two Windows plan examples in
_help.pyto explicitly pass--is-linux false, consistent with the documented default.Two unit tests added to
TestCreateAppServicePlanDefaultsto guard the default behavior:test_is_linux_none_defaults_to_linux— omitting--is-linuxresolves toreserved=Truetest_is_linux_false_creates_windows_plan—--is-linux falseresolves toreserved=FalseTesting Guide
az appservice plan create --help # Verify Windows plan examples include --is-linux false python -m unittest azure.cli.command_modules.appservice.tests.latest.test_webapp_commands_thru_mock.TestCreateAppServicePlanDefaults -vHistory Notes
[AppService]
az appservice plan create: Fix Windows plan help examples to include--is-linux false, consistent with the default Linux behavior when the flag is omittedThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.