Skip to content

azure.ai.connections: own the azure.ai.connection service block in azure.yaml - #9997

Merged
JerryYang (JerryYangKai) merged 4 commits into
mainfrom
kaiyan/refactor
Sep 11, 2026
Merged

azure.ai.connections: own the azure.ai.connection service block in azure.yaml#9997
JerryYang (JerryYangKai) merged 4 commits into
mainfrom
kaiyan/refactor

Conversation

@JerryYangKai

@JerryYangKai JerryYang (JerryYangKai) commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

The same PR with #9899
That one is close by me, and because of some wrong operation, cannot reopen

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 4 pipeline(s).
18 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@github-actions

Copy link
Copy Markdown

📋 Prioritization Note

Thanks for the contribution! The linked issue isn't in the current milestone yet.
Thank you for logging this issue; our team is reviewing it. If you need urgent prioritization, tag Rick Winter (@RickWinter) and Kristen Womack (@kristenwomack) to let us know.

@github-actions github-actions Bot added ext-agents azure.ai.agents extension ext-connections azure.ai.connections extension ext-projects azure.ai.projects extension labels Sep 11, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The breaking, cross-extension lifecycle migration spans 112 files and lacks live Azure deployment validation.

Pull request overview

Moves Foundry Connection lifecycle ownership from Projects/Agents infrastructure provisioning to the Connections extension.

Changes:

  • Adds deployment-time Connection reconciliation and project-scoped readiness markers.
  • Removes generic Connection resources from generated Bicep/Terraform.
  • Updates Agent composition, dependency validation, schemas, commands, tests, and migration guidance.
File summaries
File Description
cli/azd/extensions/ai-non-interactive.md Updates non-interactive guidance.
cli/azd/extensions/azure.ai.agents/README.md Documents breaking Agent migration.
azure.ai.agents/internal/cmd/add.go Introduces noun-first dependency commands.
azure.ai.agents/internal/cmd/add_test.go Tests renamed composition commands.
azure.ai.agents/internal/cmd/agent_definition_edit.go Updates Agent definition editing.
azure.ai.agents/internal/cmd/agent_deploy_test.go Removes standalone-deploy coverage.
azure.ai.agents/internal/cmd/deploy.go Removes standalone Agent deployment.
azure.ai.agents/internal/cmd/doctor/checks_connections.go Updates Connection diagnostics.
azure.ai.agents/internal/cmd/doctor/checks_connections_test.go Tests Connection diagnostics.
azure.ai.agents/internal/cmd/doctor/checks_toolboxes.go Updates Toolbox diagnostics.
azure.ai.agents/internal/cmd/doctor/checks_toolboxes_test.go Tests Toolbox diagnostics.
azure.ai.agents/internal/cmd/ejection_validation.go Enforces migration during ejection.
azure.ai.agents/internal/cmd/init.go Updates split-service generation.
azure.ai.agents/internal/cmd/init_infra.go Removes Connection infrastructure synthesis.
azure.ai.agents/internal/cmd/init_infra_test.go Tests new infrastructure ownership.
azure.ai.agents/internal/cmd/listen.go Removes legacy Connection projection.
azure.ai.agents/internal/cmd/listen_test.go Tests extension-host behavior.
azure.ai.agents/internal/cmd/nextstep/connections.go Updates Connection next steps.
azure.ai.agents/internal/cmd/nextstep/resolver.go Revises dependency guidance.
azure.ai.agents/internal/cmd/nextstep/resolver_test.go Tests revised guidance.
azure.ai.agents/internal/cmd/pending_provision.go Removes pending Connection provisioning.
azure.ai.agents/internal/cmd/pending_provision_test.go Updates pending-state tests.
azure.ai.agents/internal/cmd/resource_ownership_test.go Tests split ownership.
azure.ai.agents/internal/cmd/resource_services.go Stops provisioning Connection services.
azure.ai.agents/internal/cmd/resource_services_test.go Tests resource-service handling.
azure.ai.agents/internal/cmd/root.go Registers new command hierarchy.
azure.ai.agents/internal/pkg/envkey/envkey.go Adds collision-free readiness keys.
azure.ai.agents/internal/pkg/envkey/envkey_test.go Tests readiness-key encoding.
azure.ai.agents/internal/project/agent_definition.go Rejects bundled resource definitions.
azure.ai.agents/internal/project/direct_deploy.go Removes direct deployment support.
azure.ai.agents/internal/project/direct_deploy_test.go Removes direct-deployment tests.
azure.ai.agents/internal/project/foundry_dependencies.go Requires per-service readiness markers.
azure.ai.agents/internal/project/foundry_dependencies_test.go Tests dependency readiness.
azure.ai.agents/internal/project/resource_ownership_test.go Tests accepted reference forms.
azure.ai.agents/internal/project/service_target_agent.go Updates Agent service deployment.
azure.ai.agents/internal/synthesis/ownership_test.go Tests synthesis ownership.
azure.ai.agents/internal/synthesis/synthesizer.go Removes Connection synthesis.
azure.ai.agents/internal/synthesis/synthesizer_test.go Updates synthesis tests.
azure.ai.agents/internal/synthesis/templates/existing-project-eject.bicep.tmpl Removes Connection parameters.
azure.ai.agents/internal/synthesis/templates/existing-project.arm.json Regenerates Connection-free ARM.
azure.ai.agents/internal/synthesis/templates/existing-project.bicep Removes Connection resources.
azure.ai.agents/internal/synthesis/templates/main.arm.json Regenerates primary ARM template.
azure.ai.agents/internal/synthesis/templates/main.bicep Removes Connection wiring.
azure.ai.agents/internal/synthesis/templates/modules/connections.bicep Deletes generic Connection module.
azure.ai.agents/internal/synthesis/templates/modules/foundry-project.bicep Retains only system ACR Connection.
azure.ai.agents/internal/synthesis/templates/modules/resources.bicep Removes generic Connection module usage.
azure.ai.agents/internal/synthesis/templates/terraform-existing-project/connections.tf Deletes Connection Terraform resources.
azure.ai.agents/internal/synthesis/templates/terraform-existing-project/outputs.tf.tmpl Removes aggregate readiness outputs.
azure.ai.agents/internal/synthesis/templates/terraform-existing-project/variables.tf Removes Connection variables.
azure.ai.agents/internal/synthesis/templates/terraform/connections.tf Deletes Connection Terraform resources.
azure.ai.agents/internal/synthesis/templates/terraform/outputs.tf.tmpl Removes Connection outputs.
azure.ai.agents/internal/synthesis/templates/terraform/variables.tf Removes Connection variables.
azure.ai.agents/schemas/azure.ai.agent.json Restricts Agent-owned resources.
azure.ai.agents/tests/cli-interactive-tester-scenarios/README.md Updates scenario documentation.
azure.ai.agents/tests/cli-interactive-tester-scenarios/fixtures/agent-dependencies/azure.yaml Updates dependency fixture.
azure.ai.agents/tests/cli-interactive-tester-scenarios/tier0/0.17-toolbox-add.yaml Tests noun-first Toolbox command.
azure.ai.agents/tests/cli-interactive-tester-scenarios/tier0/0.18-connection-add.yaml Tests noun-first Connection command.
azure.ai.agents/tests/cli-interactive-tester-scenarios/tier0/0.19-standalone-deploy-migration.yaml Tests standalone-deploy migration.
azure.ai.connections/README.md Documents ownership and migration.
azure.ai.connections/internal/cmd/connection.go Shares stricter Connection validation.
azure.ai.connections/internal/cmd/connection_context.go Resolves selected-environment context.
azure.ai.connections/internal/cmd/connection_context_test.go Tests environment isolation.
azure.ai.connections/internal/cmd/connection_test.go Updates Connection command coverage.
azure.ai.connections/internal/cmd/connection_validation.go Adds payload/authentication validation.
azure.ai.connections/internal/cmd/connection_validation_test.go Tests validation behavior.
azure.ai.connections/internal/cmd/delete_readiness_test.go Tests marker cleanup on deletion.
azure.ai.connections/internal/cmd/endpoint.go Updates endpoint resolution.
azure.ai.connections/internal/cmd/endpoint_test.go Tests endpoint resolution.
azure.ai.connections/internal/cmd/providers_manifest_test.go Verifies service-target registration.
azure.ai.connections/internal/cmd/raw_connection.go Defines raw ARM payload handling.
azure.ai.connections/internal/cmd/root.go Registers the Connection service target.
azure.ai.connections/internal/cmd/service_config_test.go Tests service configuration parsing.
azure.ai.connections/internal/cmd/service_target.go Implements deployment reconciliation.
azure.ai.connections/internal/cmd/service_target_test.go Tests deployment lifecycle behavior.
azure.ai.connections/internal/foundry/projectctx/resolver.go Adds strict named-environment resolution.
azure.ai.connections/internal/foundry/projectctx/resolver_test.go Tests project context resolution.
azure.ai.connections/internal/foundry/projectctx/types.go Updates project-context types.
azure.ai.connections/internal/pkg/envkey/envkey.go Produces readiness-marker keys.
azure.ai.connections/internal/pkg/envkey/envkey_test.go Tests marker-key encoding.
azure.ai.connections/schemas/azure.ai.connection.json Documents service payload semantics.
azure.ai.projects/README.md Documents the ownership migration.
azure.ai.projects/internal/cmd/ejection_validation.go Validates ejected infrastructure.
azure.ai.projects/internal/cmd/project_add.go Removes Connection authoring flow.
azure.ai.projects/internal/cmd/project_deployment_add_test.go Updates project-authoring tests.
azure.ai.projects/internal/cmd/project_existing_infra.go Removes Connection ejection inputs.
azure.ai.projects/internal/cmd/project_ownership_test.go Tests Project ownership boundaries.
azure.ai.projects/internal/cmd/project_transaction_test.go Tests transactional migration failures.
azure.ai.projects/internal/provisioning/connection_migration.go Rejects legacy compiled Connection resources.
azure.ai.projects/internal/provisioning/connection_migration_test.go Tests migration detection and exemptions.
azure.ai.projects/internal/provisioning/connection_name_test.go Updates Connection-name coverage.
azure.ai.projects/internal/provisioning/foundry_provisioning_provider.go Removes generic Connection provisioning.
azure.ai.projects/internal/provisioning/foundry_provisioning_provider_resolveenv_test.go Updates environment-resolution tests.
azure.ai.projects/internal/provisioning/foundry_provisioning_provider_test.go Tests revised provisioning behavior.
azure.ai.projects/internal/provisioning/ondisk_template.go Validates compiled on-disk templates.
azure.ai.projects/internal/provisioning/ondisk_template_test.go Tests on-disk migration validation.
azure.ai.projects/internal/synthesis/ownership_test.go Tests synthesis boundaries.
azure.ai.projects/internal/synthesis/synthesizer.go Removes Connection collection.
azure.ai.projects/internal/synthesis/synthesizer_test.go Updates synthesis coverage.
azure.ai.projects/internal/synthesis/templates/existing-project-eject.bicep.tmpl Removes Connection inputs.
azure.ai.projects/internal/synthesis/templates/existing-project.arm.json Regenerates Connection-free ARM.
azure.ai.projects/internal/synthesis/templates/existing-project.bicep Removes Connection resources.
azure.ai.projects/internal/synthesis/templates/main.arm.json Regenerates primary ARM template.
azure.ai.projects/internal/synthesis/templates/main.bicep Removes Connection wiring.
azure.ai.projects/internal/synthesis/templates/modules/connections.bicep Deletes generic Connection module.
azure.ai.projects/internal/synthesis/templates/modules/foundry-project.bicep Preserves only system ACR wiring.
azure.ai.projects/internal/synthesis/templates/modules/resources.bicep Removes generic Connection provisioning.
azure.ai.projects/internal/synthesis/templates/terraform-existing-project/connections.tf Deletes Connection resources.
azure.ai.projects/internal/synthesis/templates/terraform-existing-project/outputs.tf.tmpl Removes readiness outputs.
azure.ai.projects/internal/synthesis/templates/terraform-existing-project/variables.tf Removes Connection variables.
azure.ai.projects/internal/synthesis/templates/terraform/connections.tf Deletes Connection resources.
azure.ai.projects/internal/synthesis/templates/terraform/outputs.tf.tmpl Removes readiness outputs.
azure.ai.projects/internal/synthesis/templates/terraform/variables.tf Removes Connection variables.
Review details
  • Files reviewed: 112/112 changed files
  • Comments generated: 0
  • Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@JerryYangKai JerryYang (JerryYangKai) changed the title refactor: move Foundry connection lifecycle to its owning extension azure.ai.connections: own the azure.ai.connection service block in azure.yaml Sep 11, 2026
Copilot AI review requested due to automatic review settings September 11, 2026 02:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

It coordinates breaking CLI, deployment, ARM, and IaC ownership changes across three extensions without live Azure validation.

Review details
  • Files reviewed: 111/111 changed files
  • Comments generated: 0 new
  • Review effort level: Balanced

Copilot AI review requested due to automatic review settings September 11, 2026 04:28

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

OAuth2 updates can discard credentials by rebuilding the replacement payload from an ARM response that never contains them.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details
  • Files reviewed: 111/111 changed files
  • Comments generated: 1
  • Review effort level: Balanced

Copilot AI review requested due to automatic review settings September 11, 2026 07:06

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The 112-file breaking ownership migration changes deployment, dependency, and generated-infrastructure contracts without live Azure validation.

Review details
  • Files reviewed: 107/118 changed files
  • Comments generated: 0 new
  • Review effort level: Balanced

@azure-sdk-automation

Copy link
Copy Markdown
Contributor

azure.ai.agents PR build

Note

This is an unsigned development build. Install it only if you trust this PR.

Install the extension:

azd ext install "https://azuresdkartifacts.z5.web.core.windows.net/azd/extensions/pr/9997/azure-ai-agents.zip"
  • Version: 1.0.0-beta.14.pr.9997.6824544
  • Merge commit: db4cde8

@azure-sdk-automation

Copy link
Copy Markdown
Contributor

azure.ai.connections PR build

Note

This is an unsigned development build. Install it only if you trust this PR.

Install the extension:

azd ext install "https://azuresdkartifacts.z5.web.core.windows.net/azd/extensions/pr/9997/azure-ai-connections.zip"
  • Version: 1.0.0-beta.6.pr.9997.6824545
  • Merge commit: db4cde8

@azure-sdk-automation

Copy link
Copy Markdown
Contributor

azure.ai.projects PR build

Note

This is an unsigned development build. Install it only if you trust this PR.

Install the extension:

azd ext install "https://azuresdkartifacts.z5.web.core.windows.net/azd/extensions/pr/9997/azure-ai-projects.zip"
  • Version: 1.0.0-beta.9.pr.9997.6824546
  • Merge commit: db4cde8

@JerryYangKai
JerryYang (JerryYangKai) merged commit bedb335 into main Sep 11, 2026
79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ext-agents azure.ai.agents extension ext-connections azure.ai.connections extension ext-projects azure.ai.projects extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

azure.ai.connections: own the azure.ai.connection service block in azure.yaml

3 participants