Capture all JDK version components when detecting releases - #899
Open
Ahmed Muhsin (ahmedmuhsin) wants to merge 1 commit into
Open
Ahmed Muhsin (ahmedmuhsin) wants to merge 1 commit into
Ahmed Muhsin (ahmedmuhsin) wants to merge 1 commit into
Conversation
The version regex matched exactly three numeric components, so a release like 21.0.12.1 was recorded as 21.0.12. That truncated version is still a real download, and validation compared the downloaded JDK against the already-truncated string using a substring test, so the wrong pin shipped without anything failing. Microsoft OpenJDK publishes three, four and five component versions (11.0.32, 21.0.12.1, 11.0.13.8.1), so capture every dotted component.
Ahmed Muhsin (ahmedmuhsin)
force-pushed
the
fix/jdk-version-parsing
branch
from
September 17, 2026 17:58
664d836 to
acb8779
Compare
Ahmed Muhsin (ahmedmuhsin)
marked this pull request as ready for review
September 17, 2026 18:07
Tsuyoshi Ushio (TsuyoshiUshio)
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The version regex matched exactly three numeric components, so Microsoft's
21.0.12.1release was recorded as21.0.12. The truncated version is still a real download, and validation compared the downloaded JDK against the already-truncated string, so the wrong pin shipped without anything failing. All four Microsoft OpenJDKs were affected this cycle.Now captures every dotted component. Microsoft publishes three, four and five component versions (
11.0.32,21.0.12.1,11.0.13.8.1).Verified by reverting the fix (14 cases fail, and only the ones that should) and restoring it. Live lookups resolve
11.0.32.1,17.0.20.1,21.0.12.1,25.0.4.1.