Fix silent no-op download of named job outputs in azure-ai-ml - #48954
Draft
mohammadsheraj with Copilot wants to merge 3 commits into
Draft
Fix silent no-op download of named job outputs in azure-ai-ml#48954mohammadsheraj with Copilot wants to merge 3 commits into
mohammadsheraj with Copilot wants to merge 3 commits into
Conversation
|
Azure Pipelines: 11 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Co-authored-by: mohammadsheraj <221899694+mohammadsheraj@users.noreply.github.com>
Co-authored-by: mohammadsheraj <221899694+mohammadsheraj@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix broken download of URI folder in version 1.35.0
Fix silent no-op download of named job outputs in azure-ai-ml
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MLClient.jobs.download(name=..., output_name=...)downloaded nothing — and raised nothing — for a job'suri_folder/uri_file/mltableoutputs. RunHistory reports a job output's type in PascalCase (UriFolder), but after the 1.35.0 msrest →arm_ml_servicemigrationget_job_output_uris_from_dataplane()filtered those types against the new enum whose values are snake_case (uri_folder), so every data output was dropped before the dataplane was ever queried.Changes
_job_ops_helper.py— added_normalize_asset_type()(lower()+ strip_) and precomputed_DATA_ASSET_TYPES/_MODEL_ASSET_TYPESsets; the dataset and model filters now match either wire spelling. Unknown and missing types are still skipped, so no dataplane calls are made for them._job_ops_helper.py— read the model dataplane response viavalues_property;model_uris.valuesresolved to the inheritedMutableMapping.valuesmethod and raisedAttributeError: 'function' object has no attribute 'items'._model_dataplane_operations.py— build the request asBatchGetResolvedUrisDto(values_property=model_ids);values=raisedTypeError: unexpected keyword argument 'values', so model outputs failed even once they passed the filter. Serialized body is unchanged ({"values": [...]}) and now matchesDatasetDataplaneOperations._job_operations.py— when an explicitly requestedoutput_namecannot be resolved, log at warning level instead of debug. Other misses (logs, default artifact store, batch scoring file) stay at debug.test_job_ops_helper.pycovers both spellings for data and model outputs, a single named output, unknown/missing types, and the asset ids sent to both dataplane clients (via the real operations classes over mocked service clients);test_job_operations.pycovers the new warning.Notes for reviewers
uri_foldersymptom but sit in the same resolution path and share the same migration root cause; without them, model outputs would still fail after the filter fix.stream_logs_until_completion'sdefault_output.job_output_type == DataType.URI_FOLDERcheck was left alone: both sides come from the control plane (JobOutputType.URI_FOLDER == DataType.URI_FOLDER == "uri_folder").