Skip to content

feat: 공개 게임 API에 활성 빌드의 캔버스 크기 노출 - #118

Open
ff1451 wants to merge 1 commit into
mainfrom
feat/t41c-public-build-canvas-dims
Open

feat: 공개 게임 API에 활성 빌드의 캔버스 크기 노출#118
ff1451 wants to merge 1 commit into
mainfrom
feat/t41c-public-build-canvas-dims

Conversation

@ff1451

@ff1451 ff1451 commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Summary

홈페이지 게임 상세 페이지 플레이어가 실제 빌드 해상도 비율로 캔버스를 렌더링하려면 canvasWidth/canvasHeight가 공개 API에도 필요하다(참고 사이트 arcade.codingbot.kr/play 구조 반영 작업 중 발견). 이미 admin 응답과 완료 웹훅에는 있던 값을 공개 GameActiveBuildResponse에도 추가한다.

검증

./gradlew test --tests "*Game*" 전체 통과.

Summary by CodeRabbit

  • New Features
    • Active game build responses now include canvas width and height information.

홈페이지 플레이어가 실제 빌드 해상도 비율로 캔버스를 맞추려면 필요하다.
canvasWidth/canvasHeight는 이미 admin 응답에는 있었고, 완료 웹훅으로
채워진다 — 공개 응답에 필드만 추가한다.
@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: 9a5ebc20-1399-4e4e-98ea-9e9f22c97de0

📥 Commits

Reviewing files that changed from the base of the PR and between faae6c1 and 630f74d.

📒 Files selected for processing (1)
  • src/main/java/com/bcsdlab/bcsdinternalapiv2/game/controller/dto/response/GameActiveBuildResponse.java

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

GameActiveBuildResponse now returns nullable canvasWidth and canvasHeight values populated from the corresponding GameBuild fields.

Changes

Active build response

Layer / File(s) Summary
Expose canvas dimensions
src/main/java/com/bcsdlab/bcsdinternalapiv2/game/controller/dto/response/GameActiveBuildResponse.java
The response record adds nullable canvasWidth and canvasHeight components. The factory method maps both values from GameBuild.

Estimated code review effort: 2 (Simple) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 630f7

The public active-build response now includes canvas width and height so players can render at the build’s intended aspect ratio. The fields are sourced from existing build metadata with no remaining concrete merge-blocking risk.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes exposing the active build canvas dimensions in the public game API. This matches the main change.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/t41c-public-build-canvas-dims

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant