test: 팀원 모집 TEAM 채팅 HTTP 인수 테스트 추가

[taejinn]

🔍 개요

• TEAM 채팅의 권한, 메시지 pagination, 읽음 cursor, READ_ONLY 동작을 실제 HTTP와 DB 경계에서 고정합니다.

• close [공통] 팀원 모집 TEAM 채팅 실제 HTTP 인수 테스트 보강 #2379

---

🚀 주요 변경 내용

• 멤버·비멤버·비로그인·잘못된 모집 ID의 200/401/403/404 경계를 검증합니다.
• 메시지 4개에서 limit=2 cursor pagination과 오래된 순서 반환을 검증합니다.
• unread 수와 조회 후 read cursor 갱신을 검증합니다.
• READ_ONLY 방 조회 200과 메시지 전송 409를 검증합니다.
• 양방향 notification/outbox의 대상·메시지 연결·개수를 검증합니다.

---

💬 참고 사항

• 영향
  • 심각도는 P2 핵심 여정 회귀 방지이며 변경 파일은 TeamRecruitmentChatApiTest 1개입니다.
  • Spring MVC → 인증 → service → MySQL → notification/outbox 저장 경계의 TEAM 채팅 HTTP 계약을 고정합니다.
• 검증
  • 인수 테스트 3개와 CI build, Unit Test Results가 통과했습니다.
• 관련 PR
  • 알림 목록·일괄 처리 테스트는 #2405에서 다룹니다.

---

✅ Checklist (완료 조건)

• 코드 스타일 가이드 준수
• 테스트 코드 포함됨
• Reviewers / Assignees / Labels 지정 완료
• 보안 및 민감 정보 검증 (API 키, 환경 변수, 개인정보 등)

Summary by CodeRabbit

• Tests
  • Added acceptance coverage for team recruitment chat access permissions.
  • Verified message history pagination, read-status updates, and notification delivery.
  • Added coverage for message sending, outbox events, and expected event payloads.
  • Confirmed read-only chat rooms reject new messages while allowing existing messages to be viewed.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: bd13fa3f-daf9-4f14-a32c-3caddf04bcd4

📥 Commits

Reviewing files that changed from the base of the PR and between cefcda7 and aae2d36.

📒 Files selected for processing (1)

• src/test/java/in/koreatech/koin/acceptance/domain/TeamRecruitmentChatApiTest.java

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

Added HTTP acceptance coverage for TEAM recruitment chat. The tests validate membership access, message pagination, read-state updates, notification and outbox persistence, and READ_ONLY room behavior.

Changes

TEAM recruitment chat validation

Layer / File(s)	Summary
Chat fixtures and request helpers src/test/java/in/koreatech/koin/acceptance/domain/TeamRecruitmentChatApiTest.java	Creates test users, recruitment data, chat rooms, tokens, messages, and helpers for request and outbox assertions.
Access and READ_ONLY boundaries src/test/java/in/koreatech/koin/acceptance/domain/TeamRecruitmentChatApiTest.java	Verifies member, anonymous, non-member, and unknown-room responses. Verifies that READ_ONLY rooms allow reads and reject message sends.
Message polling and notification events src/test/java/in/koreatech/koin/acceptance/domain/TeamRecruitmentChatApiTest.java	Verifies message responses, cursor pagination, unread-state updates, notification records, and pending outbox payloads.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Merge Risk: 🔵 Low · up to aae2d

Although the PR adds HTTP acceptance tests, it also changes notification read and delete behavior to recipient-scoped conditional updates; the change appears bounded and idempotent, but its production scope is broader than the stated test-only change, so merge with explicit owner awareness and focused notification regression checks.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 9 functions across 1 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the main change: adding HTTP acceptance tests for team recruitment TEAM chat.
Linked Issues check	✅ Passed	The test covers the linked issue requirements, including TEAM room access control, cursor pagination, unread/read cursor updates, READ_ONLY behavior, and notification/outbox linkage.
Out of Scope Changes check	✅ Passed	The pull request adds one acceptance test file and stays within the linked issue scope. It does not add excluded features such as DIRECT room concurrency, notification list processing, or Firebase FCM…

Full details: Out of Scope Changes check

Explanation

The pull request adds one acceptance test file and stays within the linked issue scope. It does not add excluded features such as DIRECT room concurrency, notification list processing, or Firebase FCM delivery.

• Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch test/2379-team-recruitment-chat-notification-http-test

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

Unit Test Results

1 137 tests   1 134 ✔️  2m 49s ⏱️
   256 suites         3 💤
   256 files           0 ❌

Results for commit aae2d36.

♻️ This comment has been updated with latest results.