Skip to content

fix: 세그먼트 미선택/무시된 스와이프에서 기록되던 식단 로깅 수정 #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oeunji wants to merge 2 commits into
base: develop
Choose a base branch
from
+44 −16
Open

fix: 세그먼트 미선택/무시된 스와이프에서 기록되던 식단 로깅 수정 #556

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e7a1db
test: 세그먼트 미선택 로깅 방지 및 무시 스와이프 로깅 방지 테스트 코드 작성
oeunji Sep 5, 2026
ed7831b
fix: 세그먼트 미선택/무시된 스와이프에서 잘못 기록되던 로깅 수정
oeunji Sep 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 23 additions & 16 deletions Koin/Presentation/Dining/Dining/DiningViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,8 +173,10 @@ final class DiningViewController: UIViewController {
zoomedImageViewController.setImage(tappedDiningImage)
self.present(zoomedImageViewController, animated: true, completion: nil)

inputSubject.send(.logEvent(EventParameter.EventLabel.Campus.menuImage, .click, "\(self.currentDiningType.name)_\(tappedPlaceText)"))

if let currentDiningType = self.currentDiningType {
inputSubject.send(.logEvent(EventParameter.EventLabel.Campus.menuImage, .click, "\(currentDiningType.name)_\(tappedPlaceText)"))
}

}.store(in: &subscriptions)

diningListCollectionView.shareButtonPublisher.sink { [weak self] item in
Expand All @@ -183,8 +185,8 @@ final class DiningViewController: UIViewController {
}.store(in: &subscriptions)

diningListCollectionView.logScrollPublisher.sink { [weak self] _ in
guard let self = self else { return }
self.inputSubject.send(.logEvent(EventParameter.EventLabel.Campus.menuTime, .scroll, self.currentDiningType.name))
guard let self = self, let currentDiningType = self.currentDiningType else { return }
self.inputSubject.send(.logEvent(EventParameter.EventLabel.Campus.menuTime, .scroll, currentDiningType.name))
}.store(in: &subscriptions)

NotificationCenter.default.publisher(for: UIApplication.willEnterForegroundNotification).sink { [weak self] _ in
Expand Down Expand Up @@ -213,21 +215,26 @@ extension DiningViewController {

@objc func handleSwipe(_ gesture: UISwipeGestureRecognizer) {
let currentSegmentIndex = diningTypeSegmentControl.selectedSegmentIndex
if gesture.direction == .left {
if currentSegmentIndex < diningTypeSegmentControl.numberOfSegments - 1 {
diningTypeSegmentControl.selectedSegmentIndex = currentSegmentIndex + 1
}
} else if gesture.direction == .right {
if currentSegmentIndex > 0 {
diningTypeSegmentControl.selectedSegmentIndex = currentSegmentIndex - 1
}
let nextSegmentIndex: Int

switch gesture.direction {
case .left: nextSegmentIndex = currentSegmentIndex + 1
case .right: nextSegmentIndex = currentSegmentIndex - 1
default: return
}

guard (0..<diningTypeSegmentControl.numberOfSegments).contains(nextSegmentIndex) else { return }

diningTypeSegmentControl.selectedSegmentIndex = nextSegmentIndex
segmentDidChange(diningTypeSegmentControl)
}

@objc private func refresh() {
inputSubject.send(.updateDisplayDateTime(nil, currentDiningType))
inputSubject.send(.logEvent(EventParameter.EventLabel.Campus.menuTime, .click, currentDiningType.name))

if let currentDiningType {
inputSubject.send(.logEvent(EventParameter.EventLabel.Campus.menuTime, .click, currentDiningType.name))
}

refreshControl.endRefreshing()
}
Expand Down Expand Up @@ -275,7 +282,7 @@ extension DiningViewController {
}

@objc private func segmentDidChange(_ sender: UISegmentedControl) {
let diningType = DiningType(segmentIndex: sender.selectedSegmentIndex) ?? .dinner
guard let diningType = DiningType(segmentIndex: sender.selectedSegmentIndex) else { return }

inputSubject.send(.updateDisplayDateTime(nil, diningType))
inputSubject.send(.logEvent(EventParameter.EventLabel.Campus.menuTime, .click, diningType.name))
Expand Down Expand Up @@ -320,8 +327,8 @@ extension DiningViewController {
diningListCollectionView.setDiningList(list)
}

private var currentDiningType: DiningType {
DiningType(segmentIndex: diningTypeSegmentControl.selectedSegmentIndex) ?? .dinner
private var currentDiningType: DiningType? {
DiningType(segmentIndex: diningTypeSegmentControl.selectedSegmentIndex)
}
}

Expand Down
21 changes: 21 additions & 0 deletions koinUnitTests/Dining/DiningLoggingTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,4 +99,25 @@ struct DiningLoggingTests {

#expect(bed.recorder.loggedEvents == [DiningLoggedEvent("menu_time", "click", "저녁")])
}

@Test("세그먼트가 선택되지 않으면 로깅하지 않는다")
func 세그먼트가_선택되지_않으면_로깅하지_않는다() {
let bed = DiningLoggingTestBed()
bed.selectSegment(-1)

bed.tapMenuImage(place: "A코너")
bed.scrollDiningList()

#expect(bed.recorder.loggedEvents.isEmpty)
}

@Test("무시된 스와이프는 로깅하지 않는다")
func 무시된_스와이프는_로깅하지_않는다() {
let bed = DiningLoggingTestBed()
bed.selectSegment(0)

bed.swipe(.right)

#expect(bed.recorder.loggedEvents.isEmpty)
}
}