Update JsRuntimeHost to latest - #1854
Merged
bkaradzic-microsoft merged 1 commit intoAug 27, 2026
Merged
Conversation
Includes fixes for zero-delay setInterval queue starvation, XHR response truncation at embedded NUL bytes, and UTF-16 TextDecoder support. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d47cbab2-d751-4cf9-984f-4412dd9ec601
bghgary
approved these changes
Aug 27, 2026
bkaradzic-microsoft
enabled auto-merge (squash)
August 27, 2026 15:16
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates the Babylon Native build’s pinned JsRuntimeHost FetchContent dependency to a newer upstream commit in order to pick up recent runtime fixes (timer queue starvation, additional TextDecoder UTF-16 support, and preserving embedded NUL bytes in XHR string responses).
Changes:
- Bump
JsRuntimeHostFetchContent_DeclareGIT_TAGfromcb988ba…to0d26362….
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
bkaradzic-microsoft
added a commit
to bkaradzic-microsoft/BabylonNative
that referenced
this pull request
Aug 27, 2026
Bring in i_data slot-overlap fix (BabylonJS#1852) and JsRuntimeHost pin (BabylonJS#1854 content via shotgun fork). Keep shotgun JsRuntimeHost/SPIRV-Cross forks, fragCoord Y flip, GPU instance repack, compute shader path, and playground enables. Resolve config by preserving shotgun enablements and taking upstream OpenGL CI exclusions where applicable. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 60c2ec68-6de1-445d-9fc9-b699db737eae
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update JsRuntimeHost from
cb988baato0d263627, picking up three fixes merged since the current pin:setIntervalfrom flooding and starving the JS dispatch queue. In BN this could indefinitely delay async shader-compilation continuations and hang scene readiness.TextDecoder, needed by EmscriptenEXPORT_ES6modules such as SPZ and CSG2/manifold.Validation
Nested BBGvalidation test, which exercises the timer-starvation regression path: 1/1 passed, exit 0.