Skip to content

test(sdk-coin-eos): add coverage for memoId=0 address handling #9314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
bitgo-ai-agent-dev wants to merge 1 commit into
base: master
Choose a base branch
from
+25 −0
Draft

test(sdk-coin-eos): add coverage for memoId=0 address handling #9314

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions modules/sdk-coin-eos/test/unit/eos.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,10 @@ describe('EOS:', function () {
addressDetails.address.should.equal('ks13k3hdui24');
addressDetails.memoId.should.equal('1');

addressDetails = basecoin.getAddressDetails('ks13k3hdui24?memoId=0');
addressDetails.address.should.equal('ks13k3hdui24');
addressDetails.memoId.should.equal('0');

(() => {
basecoin.getAddressDetails('ks13k3hdui24?memoId=1&memoId=2');
}).should.throw();
Expand All @@ -52,6 +56,7 @@ describe('EOS:', function () {
basecoin.isValidAddress('ks13kdh245ls').should.equal(true);
basecoin.isValidAddress('ks13k3hdui24?memoId=1').should.equal(true);
basecoin.isValidAddress('ks13k3hdui24?memoId=x').should.equal(true);
basecoin.isValidAddress('ks13k3hdui24?memoId=0').should.equal(true);
});

it('verifyAddress should work', async function () {
Expand All @@ -63,6 +68,10 @@ describe('EOS:', function () {
address: 'ks13kdh245ls?memoId=1',
rootAddress: 'ks13kdh245ls',
});
await basecoin.verifyAddress({
address: 'ks13kdh245ls?memoId=0',
rootAddress: 'ks13kdh245ls',
});

assert.rejects(basecoin.verifyAddress({ address: 'i1skda3kso43=x', rootAddress: 'i1skda3kso43' }));
assert.rejects(basecoin.verifyAddress({ address: 'i1skda3kso43?memoId=243432', rootAddress: 'ks13kdh245ls' }));
Expand All @@ -83,6 +92,7 @@ describe('EOS:', function () {
});

it('isValidMemoId should work', function () {
basecoin.isValidMemoId('0').should.equal(true);
basecoin.isValidMemoId('1').should.equal(true);
basecoin.isValidMemoId('123abc').should.equal(true);
basecoin.isValidMemoId(EosInputs.string257CharsLong).should.equal(false);
Expand Down Expand Up @@ -511,5 +521,20 @@ describe('EOS:', function () {
const validTransaction = await basecoin.verifyTransaction({ txParams, txPrebuild, wallet, verification });
validTransaction.should.equal(true);
});

it('should verify a transaction with memoId=0', async function () {
const txPrebuild = newTxPrebuild();
// Transaction with memo='0' (memoId zero is the first receive address)
txPrebuild.txHex =
'2a02a0053e5a8cf73a56ba0fda11e4d92e0238a4a2aa74fccf46d5a9107468401e0c7a61a3a7b5e7c4470000000100408c7a02ea3055000000000085269d00030233330100a6823403ea3055000000572d3ccdcd0120ceb8437333427c00000000a8ed32322220ceb8437333427c20825019ab3ca98be80300000000000004454f5300000000013000000000000000000000000000000000000000000000000000000000000000000000';
txPrebuild.transaction.packed_trx =
'1e0c7a61a3a7b5e7c4470000000100408c7a02ea3055000000000085269d00030233330100a6823403ea3055000000572d3ccdcd0120ceb8437333427c00000000a8ed32322220ceb8437333427c20825019ab3ca98be80300000000000004454f5300000000013000';
const txParams = newTxParams();
txParams.recipients[0].address = 'lionteste212?memoId=0';
txParams.txPrebuild = txPrebuild;

const validTransaction = await basecoin.verifyTransaction({ txParams, txPrebuild, wallet, verification });
validTransaction.should.equal(true);
});
});
});
Loading