Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A temporary backend failure emits an error update, but a successful later tick currently emits nothing when the stored swap record stays unchanged. Subscribers can therefore keep displaying an error after the driver has recovered. Store load and list failures are also silently discarded by the sweep.
This change emits a recovery update when a successful tick clears an error, reports failed loads through the existing per-swap update stream, and propagates list failures to run so they are logged with tracing before the next retry. Successful ticks without a change or recovery still stay quiet. The public run API and record persistence behavior are preserved.
The driver feature gains an optional direct tracing dependency using the version already in the lockfile. The integration overview documents recovery notifications and the tracing subscriber needed to observe store-wide failures.
Validation: three driver regression tests cover unchanged-record recovery, failed loads and recovery, and failed listing followed by a successful retry. The first two failed against the original implementation and pass with the fix. The full workspace suite passes with all features and the locked dependencies: 83 core tests and 43 SDK tests. The driver-only feature build, cargo fmt --all --check, and git diff --check also pass.
Tested in Ubuntu on WSL using the repository's pinned nightly-2026-05-01 toolchain. Fixtures are offline; live swaps and WebAssembly builds were not exercised.