Skip to content

fix: report driver storage errors and error recovery - #1

Open
agammann wants to merge 1 commit into
Blockstream:mainfrom
agammann:fix/driver-error-reporting
Open

agammann wants to merge 1 commit into
Blockstream:mainfrom
agammann:fix/driver-error-reporting

Conversation

@agammann

Copy link
Copy Markdown

A temporary backend failure emits an error update, but a successful later tick currently emits nothing when the stored swap record stays unchanged. Subscribers can therefore keep displaying an error after the driver has recovered. Store load and list failures are also silently discarded by the sweep.

This change emits a recovery update when a successful tick clears an error, reports failed loads through the existing per-swap update stream, and propagates list failures to run so they are logged with tracing before the next retry. Successful ticks without a change or recovery still stay quiet. The public run API and record persistence behavior are preserved.

The driver feature gains an optional direct tracing dependency using the version already in the lockfile. The integration overview documents recovery notifications and the tracing subscriber needed to observe store-wide failures.

Validation: three driver regression tests cover unchanged-record recovery, failed loads and recovery, and failed listing followed by a successful retry. The first two failed against the original implementation and pass with the fix. The full workspace suite passes with all features and the locked dependencies: 83 core tests and 43 SDK tests. The driver-only feature build, cargo fmt --all --check, and git diff --check also pass.

Tested in Ubuntu on WSL using the repository's pinned nightly-2026-05-01 toolchain. Fixtures are offline; live swaps and WebAssembly builds were not exercised.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant