feat(clips): refine Dictate and empty states - #5579
Conversation
|
Here's a visual recap of what changed: Open the full interactive recap |
There was a problem hiding this comment.
Builder reviewed your changes and found 2 potential issues 🟡
Review Details
Incremental Code Review Summary
The latest head keeps the prior Dictate, empty-state, and localization fixes, but the previously reported owner-only deletion authorization and Library empty/no-results search regressions remain unresolved and are still visible in existing review threads; they are not duplicated here.
Two new Dictate regressions were identified:
- 🟡 MEDIUM — Vocabulary management is hidden until a dictation exists or capture is active, preventing first-time users from configuring recognition terms before their first capture.
- 🟡 MEDIUM — After cleanup creates
cleanedText, the expanded card remains on the Original tab because the view effect only handles removal of processed text; the successful cleanup result is not surfaced automatically.
The PR remains high risk because it contains destructive dictation deletion. Focused guards and tests were reported as passing where the repository aliases resolved; some direct test invocations remain environment/alias constrained.
🧪 Browser testing: Will run after this review (PR touches UI code)

Summary
Validation