fix: keep beta prebuilt auth migrations on the right database - #5595
Conversation
…y-prebuilt-workflow.test.ts, scripts/guard-netlify-prebuilt-workflow.ts (3 files)
|
Here's a visual recap of what changed: Open the full interactive recap |
…y-prebuilt-workflow.test.ts, scripts/guard-netlify-prebuilt-workflow.ts (3 files)
…y-prebuilt-workflow.test.ts, scripts/guard-netlify-prebuilt-workflow.ts (3 files)
…y-prebuilt-workflow.test.ts, scripts/guard-netlify-prebuilt-workflow.ts (3 files)
…y-prebuilt-workflow.test.ts, scripts/guard-netlify-prebuilt-workflow.ts (3 files)
…y-prebuilt-workflow.test.ts, scripts/guard-netlify-prebuilt-workflow.ts (3 files)
…y-prebuilt-workflow.test.ts, scripts/guard-netlify-prebuilt-workflow.ts (3 files)
…y-prebuilt-workflow.test.ts, scripts/guard-netlify-prebuilt-workflow.ts (3 files)
There was a problem hiding this comment.
Builder reviewed your changes — looks good ✅
Review Details
Incremental Code Review Summary
The latest revision addresses all three previously open comments. Beta baseline capture now occurs before the unlock, the rollback failure path throws when no deploy is available instead of suppressing the failure, and the beta failure cleanup was moved after the final cache and docs verification steps. The cleanup now covers failures across the full beta cutover sequence.
Three parallel incremental reviews found no new confirmed issues. They specifically checked baseline capture and unlock ordering, queue-drain behavior, rollback pinning, pending restore handling, and the final cleanup placement. The focused guard/test updates are consistent with the new ordering and failure paths.
Risk remains standard because this is deployment and rollback orchestration. Browser testing is not applicable because no user-facing UI changed.
🧪 Browser testing: Skipped — PR only modifies backend/config/docs, no UI impact

Summary
Validation
corepack pnpm test:netlify-prebuilt-workflowcorepack pnpm guard:netlify-prebuilt-workflowcorepack pnpm exec oxfmt --check scripts/guard-netlify-prebuilt-workflow.ts scripts/guard-netlify-prebuilt-workflow.test.ts