Skip to content

fix: keep beta prebuilt auth migrations on the right database - #5595

Merged
steve8708 merged 8 commits into
mainfrom
steve8708/changes-100040
Sep 22, 2026
Merged

steve8708 merged 8 commits into
mainfrom
steve8708/changes-100040

Conversation

@steve8708

Copy link
Copy Markdown
Contributor

Summary

  • Resolve dedicated beta database URLs before shared production database mirrors.
  • Restore the documented shared-database fallback for beta sites whose Netlify secret is not exportable.
  • Keep strict post-publish health, schema, and auth smoke as the gate for non-exportable targets.

Validation

  • corepack pnpm test:netlify-prebuilt-workflow
  • corepack pnpm guard:netlify-prebuilt-workflow
  • corepack pnpm exec oxfmt --check scripts/guard-netlify-prebuilt-workflow.ts scripts/guard-netlify-prebuilt-workflow.test.ts

…y-prebuilt-workflow.test.ts, scripts/guard-netlify-prebuilt-workflow.ts (3 files)
@github-actions

github-actions Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Here's a visual recap of what changed:

Visual recap

Open the full interactive recap

builder-io-integration[bot]

This comment was marked as outdated.

…y-prebuilt-workflow.test.ts, scripts/guard-netlify-prebuilt-workflow.ts (3 files)
builder-io-integration[bot]

This comment was marked as outdated.

@github-actions
github-actions Bot temporarily deployed to pr-5595-clips September 22, 2026 04:47 Destroyed
@github-actions
github-actions Bot temporarily deployed to pr-5595-slides September 22, 2026 04:47 Destroyed
@github-actions
github-actions Bot temporarily deployed to pr-5595-mail September 22, 2026 04:47 Destroyed
@github-actions
github-actions Bot temporarily deployed to pr-5595-assets September 22, 2026 04:47 Destroyed
@github-actions
github-actions Bot temporarily deployed to pr-5595-calendar September 22, 2026 04:47 Destroyed
@github-actions
github-actions Bot temporarily deployed to pr-5595-forms September 22, 2026 04:47 Destroyed
@github-actions
github-actions Bot temporarily deployed to pr-5595-analytics September 22, 2026 04:47 Destroyed
@github-actions
github-actions Bot temporarily deployed to pr-5595-content September 22, 2026 04:47 Destroyed
@github-actions
github-actions Bot temporarily deployed to pr-5595-fw September 22, 2026 04:47 Destroyed
@github-actions
github-actions Bot temporarily deployed to pr-5595-design September 22, 2026 04:47 Destroyed
@github-actions
github-actions Bot temporarily deployed to pr-5595-dispatch September 22, 2026 04:47 Destroyed
@github-actions
github-actions Bot temporarily deployed to pr-5595-starter September 22, 2026 04:48 Destroyed
@github-actions
github-actions Bot temporarily deployed to pr-5595-plan September 22, 2026 04:48 Destroyed
…y-prebuilt-workflow.test.ts, scripts/guard-netlify-prebuilt-workflow.ts (3 files)
builder-io-integration[bot]

This comment was marked as outdated.

…y-prebuilt-workflow.test.ts, scripts/guard-netlify-prebuilt-workflow.ts (3 files)
builder-io-integration[bot]

This comment was marked as outdated.

…y-prebuilt-workflow.test.ts, scripts/guard-netlify-prebuilt-workflow.ts (3 files)
builder-io-integration[bot]

This comment was marked as outdated.

…y-prebuilt-workflow.test.ts, scripts/guard-netlify-prebuilt-workflow.ts (3 files)
builder-io-integration[bot]

This comment was marked as outdated.

@github-actions
github-actions Bot temporarily deployed to pr-5595-calendar September 22, 2026 05:54 Destroyed
@github-actions
github-actions Bot temporarily deployed to pr-5595-mail September 22, 2026 05:54 Destroyed
@github-actions
github-actions Bot temporarily deployed to pr-5595-analytics September 22, 2026 05:54 Destroyed
@github-actions
github-actions Bot temporarily deployed to pr-5595-fw September 22, 2026 05:54 Destroyed
@github-actions
github-actions Bot temporarily deployed to pr-5595-slides September 22, 2026 05:54 Destroyed
@github-actions
github-actions Bot temporarily deployed to pr-5595-starter September 22, 2026 05:54 Destroyed
@github-actions
github-actions Bot temporarily deployed to pr-5595-clips September 22, 2026 05:54 Destroyed
@github-actions
github-actions Bot temporarily deployed to pr-5595-forms September 22, 2026 05:54 Destroyed
@github-actions
github-actions Bot temporarily deployed to pr-5595-design September 22, 2026 05:54 Destroyed
@github-actions
github-actions Bot temporarily deployed to pr-5595-plan September 22, 2026 05:54 Destroyed
@github-actions
github-actions Bot temporarily deployed to pr-5595-dispatch September 22, 2026 05:54 Destroyed
@github-actions
github-actions Bot temporarily deployed to pr-5595-assets September 22, 2026 05:55 Destroyed
@github-actions
github-actions Bot temporarily deployed to pr-5595-content September 22, 2026 05:55 Destroyed
…y-prebuilt-workflow.test.ts, scripts/guard-netlify-prebuilt-workflow.ts (3 files)
builder-io-integration[bot]

This comment was marked as outdated.

…y-prebuilt-workflow.test.ts, scripts/guard-netlify-prebuilt-workflow.ts (3 files)

@builder-io-integration builder-io-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builder reviewed your changes — looks good ✅

Review Details

Incremental Code Review Summary

The latest revision addresses all three previously open comments. Beta baseline capture now occurs before the unlock, the rollback failure path throws when no deploy is available instead of suppressing the failure, and the beta failure cleanup was moved after the final cache and docs verification steps. The cleanup now covers failures across the full beta cutover sequence.

Three parallel incremental reviews found no new confirmed issues. They specifically checked baseline capture and unlock ordering, queue-drain behavior, rollback pinning, pending restore handling, and the final cleanup placement. The focused guard/test updates are consistent with the new ordering and failure paths.

Risk remains standard because this is deployment and rollback orchestration. Browser testing is not applicable because no user-facing UI changed.

🧪 Browser testing: Skipped — PR only modifies backend/config/docs, no UI impact

@github-actions
github-actions Bot temporarily deployed to pr-5595-fw September 22, 2026 06:36 Destroyed
@github-actions
github-actions Bot temporarily deployed to pr-5595-clips September 22, 2026 06:36 Destroyed
@github-actions
github-actions Bot temporarily deployed to pr-5595-slides September 22, 2026 06:36 Destroyed
@github-actions
github-actions Bot temporarily deployed to pr-5595-starter September 22, 2026 06:36 Destroyed
@github-actions
github-actions Bot temporarily deployed to pr-5595-design September 22, 2026 06:36 Destroyed
@github-actions
github-actions Bot temporarily deployed to pr-5595-calendar September 22, 2026 06:36 Destroyed
@github-actions
github-actions Bot temporarily deployed to pr-5595-plan September 22, 2026 06:36 Destroyed
@github-actions
github-actions Bot temporarily deployed to pr-5595-content September 22, 2026 06:36 Destroyed
@github-actions
github-actions Bot temporarily deployed to pr-5595-mail September 22, 2026 06:36 Destroyed
@github-actions
github-actions Bot temporarily deployed to pr-5595-forms September 22, 2026 06:36 Destroyed
@github-actions
github-actions Bot temporarily deployed to pr-5595-dispatch September 22, 2026 06:36 Destroyed
@github-actions
github-actions Bot temporarily deployed to pr-5595-assets September 22, 2026 06:36 Destroyed
@github-actions
github-actions Bot temporarily deployed to pr-5595-analytics September 22, 2026 06:36 Destroyed
@steve8708
steve8708 merged commit aba8c52 into main Sep 22, 2026
84 checks passed
@steve8708
steve8708 deleted the steve8708/changes-100040 branch September 22, 2026 06:51

This branch was successfully deployed

No deployments
pr-5595-analytics — a9ff9f93 Deployed Sep 22, 2026 by github-actions[bot]
pr-5595-assets — a9ff9f93 Deployed Sep 22, 2026 by github-actions[bot]
pr-5595-dispatch — a9ff9f93 Deployed Sep 22, 2026 by github-actions[bot]
pr-5595-forms — a9ff9f93 Deployed Sep 22, 2026 by github-actions[bot]
pr-5595-mail — a9ff9f93 Deployed Sep 22, 2026 by github-actions[bot]
pr-5595-content — a9ff9f93 Deployed Sep 22, 2026 by github-actions[bot]
pr-5595-starter — a9ff9f93 Deployed Sep 22, 2026 by github-actions[bot]
pr-5595-clips — a9ff9f93 Deployed Sep 22, 2026 by github-actions[bot]
pr-5595-slides — a9ff9f93 Deployed Sep 22, 2026 by github-actions[bot]
pr-5595-design — a9ff9f93 Deployed Sep 22, 2026 by github-actions[bot]
pr-5595-calendar — a9ff9f93 Deployed Sep 22, 2026 by github-actions[bot]
pr-5595-plan — a9ff9f93 Deployed Sep 22, 2026 by github-actions[bot]
pr-5595-fw — a9ff9f93 Deployed Sep 22, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant