Make Clips public links login-free

[steve8708]

What changed\n\n- Let legacy /r/:recordingId links reach the existing anonymous fallback instead of being intercepted by the app-wide session redirect.\n- Keep signed-in /r/:recordingId owner playback behavior unchanged.\n- Emit canonical /share/:id links for server-generated recording resources.\n\n## Verification\n\n- Focused Clips tests: 22 passed\n- Clips typecheck: passed\n- pnpm guards: 77 checks passed\n- Clips production build: passed\n\nThe beta deployment is triggered by merge and is outside this PR validation.

[github-actions]

Visual recap — generation failed

The visual recap could not be generated for this pull request. This is informational only and does not block the PR.

Diagnostic:

No plan URL: Repair changed too much of targeted file plan.mdx; expected a localized parser fix.

Agent output: Repaired recap-source.json: converted the four escaped diagram code-fence markers into valid MDX fences. JSON remains valid and mdx["plan.mdx"] is non-empty. --- ⠀ 🟢 Parser-targeted recap source repair is complete. stderr: Reading additional input from stdin...

[builder-io-integration]

Builder reviewed your changes — looks good ✅

Review Details

Incremental Code Review Summary

The latest commit addresses the previous review comment: the anonymous legacy /r/:recordingId fallback now uses buildShareContinuationQuery to preserve normalized playback position (at, including legacy t) and panel, while retaining only approved public continuation values and excluding sensitive parameters. The session bypass remains narrowly scoped to /r/, and server-generated recording links still use the encoded canonical /share/:id path.

I reviewed the updated redirect flow, access-control branches, route matching, and added route assertions with two independent code-review agents. No new actionable issues were found. The previous comment was verified fixed and resolved before this review.

Risk level: High, because this PR changes authentication/session gating and public resource access. Focused tests reported by the agents passed, including the public path, recording route, and share-link coverage.

🧪 Browser testing: Full verification was attempted, but all 13 cases remained unverified because Chrome MCP tools were unavailable to the executors despite a healthy dev server. A browser run with working Chrome tooling is still needed.