Skip to content
This repository was archived by the owner on Sep 7, 2025. It is now read-only.

CI that builds archives: - #7

Open
walksanatora wants to merge 15 commits into
CC-YouCube:mainfrom
walksanatora:main
Open

walksanatora wants to merge 15 commits into
CC-YouCube:mainfrom
walksanatora:main

Conversation

@walksanatora

@walksanatora walksanatora commented Jan 14, 2023

Copy link
Copy Markdown
Contributor

Description

Fixes half of #5

Type of change

GithubActions

How Has This Been Tested?

by running it and tweaking the CC folder

Test Configuration:

  • read the workflow file

Checklist

  • My code follows the style guidelines of this project (all lints have passed)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Should i add Lua minification then PR it

@Commandcracker

Copy link
Copy Markdown
Member

minified-src is not minified ?_?

@walksanatora

Copy link
Copy Markdown
Contributor Author

yep currently minification is broken
i am working on it
but archive generation works
(the github action runs locally and works, but when running in actions it does not work)

@Commandcracker
Commandcracker self-requested a review May 1, 2023 17:11
@Commandcracker Commandcracker added CI/CD CI/CD related issue enhancement New feature or request labels May 1, 2023
@Commandcracker Commandcracker linked an issue May 1, 2023 that may be closed by this pull request

@Commandcracker Commandcracker left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace the minified version of LD.lua with the original and add a comment with a link to the GH repo of LD.lua if there is one. Also Rename LD.lua to something more descriptive.

@walksanatora

walksanatora commented May 1, 2023

Copy link
Copy Markdown
Contributor Author

you want to embed the full un-minified LD.lua?
(also i have alot of notifications today)

@Commandcracker

Copy link
Copy Markdown
Member

you want to embed the full un-minified LD.lua? (also i have alot of notifications today)

LibDeflate is only used to build it right ?
Then having the un-minified will help debugging

@walksanatora

Copy link
Copy Markdown
Contributor Author

I just noticed LibDeflate is not included in the computer :>

@Commandcracker

Commandcracker commented May 1, 2023

Copy link
Copy Markdown
Member

It's ignoring symlinks in GH actions !?
(I'm using act)

| rom
LD.lua        buildimgs.lua rerun.txt
startup.lua   yc
Not a directory
[build] #opts 4
[build] output_base output/yc
[build] extraction path ''
[build] validating files
buildimgs.lua:40: File/Folder does not exist:
| yc/lib
| CC runner did not timeout

@walksanatora

Copy link
Copy Markdown
Contributor Author

yeah i am gonna have to add a run ln -s $PWD/yc ../../../src iirc

@Commandcracker

Copy link
Copy Markdown
Member

or cp :P

@walksanatora

Copy link
Copy Markdown
Contributor Author

why would I copy all the files from /src when I can just link them?

This branch has not been deployed

No deployments
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

CI/CD CI/CD related issue enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Re: Minification and CI

2 participants