fix: Prevent premature analysis termination when analyzing entire game - #314
Open
kazarmy wants to merge 2 commits into
Open
fix: Prevent premature analysis termination when analyzing entire game#314kazarmy wants to merge 2 commits into
kazarmy wants to merge 2 commits into
Conversation
|
@kazarmy is attempting to deploy a commit to the Maia Platform Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #313.
This PR prevents premature analysis termination when using the "Analyze entire game" feature with depth 18 (the Maia model used is Maia 600). The bug manifests itself by the UI stopping at depth 17 in terms of Stockfish evaluations, and apparently is due to "Analyze entire game" going through the moves a bit too quickly. This bug can reliably be seen via the game https://lichess.org/XOUl8ewt at move
59... Kb6. Before this fix, this move is consistently a Mistake (yellow); after this fix, this move is consistently a Blunder (red), and tracing reveals a considerable difference in Stockfish evaluations for this move between depth 17 and depth 18.