Skip to content

[To dev/1.3] [Pipe] Avoid no-op consensus writes for covered progress (#18574) #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Caideyipi wants to merge 1 commit into from
Closed

[To dev/1.3] [Pipe] Avoid no-op consensus writes for covered progress (#18574) #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 7 additions & 13 deletions ...ache/iotdb/confignode/manager/pipe/coordinator/runtime/heartbeat/PipeHeartbeatParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,18 +192,12 @@ private void parseHeartbeatAndSaveMetaChangeLocally(
}

// Update progress index
if (!(runtimeMetaFromCoordinator
.getValue()
.getProgressIndex()
.isAfter(runtimeMetaFromAgent.getProgressIndex())
|| runtimeMetaFromCoordinator
.getValue()
.getProgressIndex()
.equals(runtimeMetaFromAgent.getProgressIndex()))) {
final ProgressIndex coordinatorProgressIndex =
runtimeMetaFromCoordinator.getValue().getProgressIndex();
final ProgressIndex agentProgressIndex = runtimeMetaFromAgent.getProgressIndex();
if (!coordinatorProgressIndex.isEqualOrAfter(agentProgressIndex)) {
final ProgressIndex updatedProgressIndex =
runtimeMetaFromCoordinator
.getValue()
.updateProgressIndex(runtimeMetaFromAgent.getProgressIndex());
runtimeMetaFromCoordinator.getValue().updateProgressIndex(agentProgressIndex);
PipeConfigNodeResourceManager.log()
.schedule(
PipeHeartbeatParser.class,
Expand All @@ -217,8 +211,8 @@ private void parseHeartbeatAndSaveMetaChangeLocally(
+ "Progress index on coordinator: {}, progress index from agent: {}, updated progressIndex: {}",
pipeMetaFromCoordinator.getStaticMeta().getPipeName(),
runtimeMetaFromCoordinator.getKey(),
runtimeMetaFromCoordinator.getValue().getProgressIndex(),
runtimeMetaFromAgent.getProgressIndex(),
coordinatorProgressIndex,
agentProgressIndex,
updatedProgressIndex));

needWriteConsensusOnConfigNodes.set(true);
Expand Down
Loading