-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat(analytics): video watch percentage and drop-off tracking #1903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ManthanNimodiya
wants to merge
8
commits into
CapSoftware:main
Choose a base branch
from
ManthanNimodiya:feat/video-watch-engagement-analytics
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
2dd8727
feat(analytics): add video watch percentage and drop-off tracking
ManthanNimodiya 9c5aca3
fix(analytics): add auth guard, skip owner self-views, robust player …
ManthanNimodiya c29503c
fix(analytics): validate videoId format instead of escapeLiteral for …
ManthanNimodiya 6fb2399
fix(analytics): drop progress events for missing videos and avoid ano…
ManthanNimodiya e99a8bf
fix(analytics): validate video id before db lookup and stop swallowin…
ManthanNimodiya df58819
fix(analytics): reuse sanitized session id and timestamp for video_pr…
ManthanNimodiya 19b779c
fix(share): remove dangling timeupdate listener when raf-deferred att…
ManthanNimodiya 6f7c8b7
fix(analytics): add percent_watched to tinybird schema, log engagemen…
ManthanNimodiya File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
video_progressbranch re-parsessessionIdand shadows the already-sanitizedsessionIdabove (including allowing the literal "anonymous" back in). That can collapse engagement sessions for clients where storage fails. Also seems better to use the already-computedtimestamp.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved in
df58819— thevideo_progressbranch no longer re-parsessessionId; it reuses the sanitizedsessionId(withrandomUUID()fallback instead of letting"anonymous"back in) and the already-computedtimestamp.tenant_idwas re-added in6f7c8b7.