fix(ENG-11334): preserve cedar_roperty_iri on api filter key collision#1012
Open
Vlad0n20 wants to merge 2 commits into
Open
fix(ENG-11334): preserve cedar_roperty_iri on api filter key collision#1012Vlad0n20 wants to merge 2 commits into
Vlad0n20 wants to merge 2 commits into
Conversation
nsemets
requested changes
Jun 15, 2026
| it('should skip the API call for a CEDAR filter found only in extraFilters (before first fetch)', () => { | ||
| const { store, mockGetFilterOptions } = setup(); | ||
| store.dispatch(new SetExtraFilters([CEDAR_FILTER])); | ||
| // Intentionally no FetchResources — state.filters is still empty |
Comment on lines
+296
to
+301
| const merged = response.filters.map((apiFilter) => { | ||
| const cedarExtra = extraFilters.find((ef) => ef.key === apiFilter.key); | ||
| return cedarExtra?.cedarPropertyIri | ||
| ? { ...apiFilter, cedarPropertyIri: cedarExtra.cedarPropertyIri, options: cedarExtra.options } | ||
| : apiFilter; | ||
| }); |
Collaborator
There was a problem hiding this comment.
Suggested change
| const merged = response.filters.map((apiFilter) => { | |
| const cedarExtra = extraFilters.find((ef) => ef.key === apiFilter.key); | |
| return cedarExtra?.cedarPropertyIri | |
| ? { ...apiFilter, cedarPropertyIri: cedarExtra.cedarPropertyIri, options: cedarExtra.options } | |
| : apiFilter; | |
| }); | |
| const extraByKey = new Map(extraFilters.map((ef) => [ef.key, ef])); | |
| const merged = response.filters.map((apiFilter) => { | |
| const cedarExtra = extraByKey.get(apiFilter.key); | |
| if (!cedarExtra) return apiFilter; | |
| return { | |
| ...apiFilter, | |
| cedarPropertyIri: cedarExtra.cedarPropertyIri, | |
| ...(cedarExtra.options !== undefined && { options: cedarExtra.options }), | |
| }; | |
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Summary of Changes
Screenshot(s)
Side Effects
QA Notes