feat(clickstack): surface ClickHouse table TTL as configurable values#250
Open
ZeynelKoca wants to merge 1 commit into
Open
feat(clickstack): surface ClickHouse table TTL as configurable values#250ZeynelKoca wants to merge 1 commit into
ZeynelKoca wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 0a08d3e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
wrn14897
approved these changes
Jul 23, 2026
wrn14897
left a comment
Collaborator
There was a problem hiding this comment.
LGTM! Thanks for the contribution
Author
|
@wrn14897 Thanks! Just to be clear, this PR exposes new configurations created in hyperdxio/hyperdx#2709 so it should be blocked for merge until the hdx PR is merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Surfaces ClickHouse table retention (TTL) as documented, configurable values in the
clickstackchart:HYPERDX_OTEL_EXPORTER_TABLES_TTL(720h) inhyperdx.configso the global retention knob is discoverable and tunable invalues.yaml.HYPERDX_OTEL_EXPORTER_LOGS_TTL/_TRACES_TTL/_METRICS_TTL/_SESSIONS_TTL— andHYPERDX_OTEL_EXPORTER_RECONCILE_TABLE_TTL, inline where the rest of the collector env lives.Why
Data retention is usually a compliance requirement (SOC 2, ISO 27001, HIPAA, PCI-DSS): security-relevant logs — and often traces — must be kept for 6–12 months, while high-volume metrics stay short to control storage cost. That's a per-signal retention policy. Today an operator has to know the exact collector env-var names and hand-inject them; this makes the retention controls first-class and self-documenting. It also complements the per-signal / reconcile capability added collector-side in hyperdxio/hyperdx#2709.
Changes
charts/clickstack/values.yaml— addHYPERDX_OTEL_EXPORTER_TABLES_TTL: "720h"tohyperdx.config, with a documented block for the per-signal overrides + reconcile flag.charts/clickstack/tests/app-configmap_test.yaml— assert the default TTL renders and that per-signal / reconcile overrides pass through.helm-charts, minor).Compatibility / sequencing
HYPERDX_OTEL_EXPORTER_TABLES_TTLalready works with current collector images (introduced in feat: introduceHYPERDX_OTEL_EXPORTER_TABLES_TTL(ClickStack OTel collector) hyperdxio/hyperdx#1720) — this just surfaces it.values.yamlso nothing changes by default.720h) matches the collector's existing default.Testing
helm lint charts/clickstack— clean.helm template— rendersHYPERDX_OTEL_EXPORTER_TABLES_TTL: "720h"inclickstack-config.helm unittest charts/clickstack— 181/181 pass (incl. 2 new config assertions).