Fix restore command for shadow pg - #86
Merged
Merged
Conversation
|
|
harshil-goel
force-pushed
the
harshil/shadow-restart-fix
branch
7 times, most recently
from
August 17, 2026 06:01
711ef70 to
867903d
Compare
harshil-goel
force-pushed
the
harshil/shadow-restart-fix
branch
from
August 17, 2026 06:09
867903d to
d5c7fdd
Compare
harshil-goel
force-pushed
the
harshil/shadow-restart-fix
branch
5 times, most recently
from
August 17, 2026 13:48
384ddc7 to
d96f680
Compare
serprex
reviewed
Aug 17, 2026
| ident.timeline, | ||
| ident.sysid.clone(), | ||
| aligned, | ||
| walsender_baseline, |
Member
There was a problem hiding this comment.
this can report server_wal_end ahead of pump, inflates lag for pg_stat_wal_receiver.latest_end_lsn
Member
|
this has some overlap with 2nd commit in #83, I went with simpler path of reporting xlogpos 0/0 |
harshil-goel
force-pushed
the
harshil/shadow-restart-fix
branch
from
August 18, 2026 04:21
d96f680 to
3b3c9db
Compare
harshil-goel
force-pushed
the
harshil/shadow-restart-fix
branch
from
August 18, 2026 10:31
3b3c9db to
96b54e6
Compare
serprex
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #85