chore(launch): final honesty review + LAUNCH-CHECKLIST evidence (#6) - #77
Merged
Conversation
Final fresh-eyes FR-9 review over the built pages (en/ar/fr) and the i18n sources. Verdict: green in all three locales — no profit claims, performance promises, urgency tactics, or testimonial-as-proof sections; standing disclaimers on every page; venue names under nominative use with no-affiliation wording; all numeric claims (14.9% win rate vs 14.88% break-even, 29% outside the allowance, ~1.2%/side taker fee, 0/90 + 0/82 matrices) match the engine's public figures; FR-8 rev markers current on every translated page (no stale banners). FR edition gaps found and fixed (EN/AR were clean): - compliance HonestBox links rendered English labels on /fr/ — now French - FR aria-labels: site nav, docs sidebar - FR compare table hidden header 'Property' -> 'Propriété' - French colon spacing on the features 'verify in the repo' lines Adds docs/LAUNCH-CHECKLIST.md recording the nine PRD §6 success criteria with evidence (HTTPS/301 checks, hreflang + parity, hourly rebuild mechanism, release.json vs GitHub latest, fetch fail-loudly CI step, Lighthouse 100/100 re-run, this review, FR shipped, secret-sweep method), with partially-external items (GSC coverage, announcement posting) stated honestly. npx astro check: 0 errors. 390px puppeteer spot-check: 0px overflow on changed pages.
|
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the two remaining items of #6 (launch hardening).
1. Final honesty review — fresh eyes, EN + AR + FR, against PRD FR-9
Reviewed the built pages (
dist/{en,ar,fr}/**, 56 pages) and the i18n sources (page dicts, ui chrome, meta/OG descriptions, RSS, 404, guides explainers, email copy infunctions/).Verdict: green in all three locales. Per FR-9 rule:
translatedFromRev=== current EN rev for 10 page families × ar/fr + 3 guide explainers — no stale banners; UGC renders in original language onlyNumeric claims verified against the engine's public numbers: 14.9% win rate vs 14.88% break-even inside the fee-free allowance, 29% outside (engine note says 29.18% — site rounds), ~1.2%/side taker fee, 0 of 90 + 0 of 82 matrices — cross-checked against
keel'sdocs/research/2026-08-20-quant-lab-note-cross-verification.mdand the roadmap PRD.Fixed in this pass (FR edition only — EN/AR were clean):
/fr/compliance/result-box links rendered English ("The experiment record / The announcement") → Frencharia-labels: site nav ("Navigation principale"), docs sidebar ("Navigation des documents")No content-dict rev bumps needed: EN source text is unchanged; the fixes are component-level label gaps, so existing markers remain accurate.
2.
docs/LAUNCH-CHECKLIST.md— nine PRD §6 criteria with evidencecurl -sItable (https 200, http/www → 301 apex), 2026-08-227 * * * *) + demonstrated by the v0.11 announcements (#485–487) landing on the next hourly build; posting itself honestly noted as the maintainer's actdata/release.jsonv0.11.0 byte-matchesreleases/latest; live install page verifiedfetch-engine-docs.mjsprocess.exit(1)on moved/missing pinned docs; cited CI step "Fetch engine docs, release, discussions"${{ secrets.* }}/ Workers env)Partially external items (GSC coverage accumulating; announcement posting under the standing rule) are stated honestly rather than claimed green.
Verification
npx astro check: 0 errors (4 hints, pre-existing)npm run build: 56 pages/fr/compliance/,/fr/features/,/fr/compare/, AR guide): 0px horizontal overflow, correctdir/lang; mobile compare card layout confirmed working over HTTPDo not merge before review — no other items touched; everything else in #6 was already done and verified.