Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
habohlin
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
habohlin
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
habohlin
added
the
Needs Review
webmonch
self-requested a review
September 24, 2026 18:34
webmonch
added
Review in progress
webmonch
reviewed
Sep 24, 2026
|
|
||
| //tests | ||
| let [pounds, pence] = toPounds("399p"); | ||
| console.log(`£${pounds}.${pence}`); |
There was a problem hiding this comment.
Can you think of a way to avoid repeating £${pounds}.${pence} after every call?"
webmonch
reviewed
Sep 24, 2026
| const hours = Number(time.slice(0, 2)); | ||
| if (hours > 12) { | ||
| return `${hours - 12}:00 pm`; | ||
| return `${hours - 12 < 10 ? "0" : ""}${hours - 12}:${time.slice(-2)} pm`; |
There was a problem hiding this comment.
Can you think of any other edge cases that could surface here?
webmonch
reviewed
Sep 24, 2026
|
|
||
| function calculateBMI(weight, height) { | ||
| // return the BMI of someone based off their weight and height | ||
| return Number.parseFloat(weight / (height * height)).toFixed(1); |
There was a problem hiding this comment.
Could be worth having another look at the Number.parseFloat docs. What type of value does it expect, and what are we passing it here?
webmonch
reviewed
Sep 24, 2026
| console.log(calculateBMI(80, 1.69)); | ||
| console.log(calculateBMI(51, 1.55)); | ||
|
|
||
| // Please could I have a little feedback about if I have refactored the function return too much? |
There was a problem hiding this comment.
One line is totally fine here! As a rule of thumb, you can keep it in one line as long as it is easy to understand.
webmonch
reviewed
Sep 24, 2026
| // This might help https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/toUpperCase | ||
|
|
||
| function toUpperSnakeCase(str) { | ||
| return str.toUpperCase().split(" ").join("_"); |
There was a problem hiding this comment.
Nice! Very clean solution and great function name.
|
Great job! Very solid and clean solutions. And kudos on doing the extend exercise! |
webmonch
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Task code
CYF-1053
Changelist
I solved the coursework in folder "Sprint-3". I also committed the "prep" folder, which you can ignore as it doesn't need grading.