London | 26-ITP-Sep | Alan Mak | Sprint 2 | Coursework by AlanGit-debug2604 · Pull Request #1570 · CodeYourFuture/Module-JavaScript-Fundamentals

AlanGit-debug2604 · 2026-09-21T23:09:54Z

Alan Mak, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

CYF-1039

Changelist
Work done in files in coursework, namely in folders:
1-key-exercises
2-mandatory-errors
3-mandatory-interpret and
4-stretch-explore

…weeen arguments

netlify · 2026-09-21T23:09:59Z

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	`92182be`
🔍 Latest deploy log	https://app.netlify.com/projects/cyf-onboarding-module/deploys/6ab4d3898e7f7b0008c1df58
😎 Deploy Preview	https://deploy-preview-1570--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	2 paths audited Performance: 100 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 86 (no change from production) PWA: - View the detailed breakdown and full score reports
🤖 Make changes	Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

abdishakoor-dev

Your 3-paths.js works for any file name, because you used lastIndexOf for ext too. Every file runs with no errors.

Some answers are missing or need another look before I can mark this Complete:

1-key-exercises/1-count.js has no answer yet. Describe what line 3 is doing, and what = does there.
1-key-exercises/4-random.js line 16: say what num is at the end. See my comment.
2-mandatory-errors/2.js, 3.js and 4.js: add the name of the error. 2.js and 3.js need a little more too. See my comments.
Delete the old code you commented out: 1.js lines 6 and 7, 2.js lines 8 and 9, 4.js lines 1 and 2, and 1-percentage-change.js line 5. Git keeps the old version for you. Keep your explanations.
3-mandatory-interpret/1-percentage-change.js: the line numbers in a) to d), and answer e). See my comments.
3-mandatory-interpret/2-time-format.js answer f): try more values. See my comment.
3-mandatory-interpret/3-to-pounds.js line 17. See my comment.
Formatting. "My changes follow the style guide" is on your checklist, and consistent formatting is part of it. The tool that does it is called Prettier. It sets spacing and indentation to one agreed style. Then a reviewer only sees the changes you meant to make. At the moment 12 of your 13 files fail that check.

Your files also have Windows line endings. So GitHub shows every line as changed, even lines you did not touch. Prettier fixes this too.

Prettier comes with the CYF extension pack from onboarding. If you are not sure you have it, open VS Code, go to Extensions, and search for CodeYourFuture Extension Pack: https://marketplace.visualstudio.com/items?itemName=CodeYourFuture.cyf-extension-pack

Then open each file you changed, right click in the editor, and choose Format Document. Pick Prettier if VS Code asks. Save, commit and push. To format every time you save, follow the format on save steps here: https://github.com/CodeYourFuture/Module-JavaScript-Fundamentals/blob/main/practical_guide.md

Add the Needs Review label again once you have pushed.

abdishakoor-dev · 2026-09-22T10:11:58Z

+// The value inside Math.floor() is its argument. The return value of this argument is expression within the yellow parenthesis.
+// The whole expression of variable "num" is that a float generated by method Math.random() is multiplied by return value of the range specified by value between declared variable by key word constant.
+// The method Math.floor() then return greatest integer of the value of this product.
+// And finally plus the value of minimum variable declared.


Your steps are in the right order. Now finish with what num is. What is the smallest value it can be? What is the largest? Run the file a few times to check.

num is a random integer between maximum and minimum inclusive.
The smallest value of 'num' can be 1

Done. Lines 18 and 19 say what num is.

abdishakoor-dev · 2026-09-22T10:11:58Z

+
+//console.log(`I was born in ${cityOfBirth}`);
+//const cityOfBirth = "Bolton";
+//The error is that the variable should be declared as a constant before it is used in the console.log statement. 


The order is the problem, you are right. Does it need to be a constant, though? Would line 4 still work with let instead of const?

The prep shows three error names: SyntaxError, TypeError and ReferenceError. Which one is this?

This is a ReferenceError.

In this code, the key word does not need to be constant, it can be let - if this is the case the variable city0fBirth can be reassigned in other lines - instead of constant (which cannot reassign variable).

Done. ReferenceError is right, and line 10 answers the let question.

abdishakoor-dev · 2026-09-22T10:11:58Z

+// Consider: Why does it give this error? Is this what I predicted? If not, what's different?
+// Then try updating the expression last4Digits is assigned to, in order to get the correct value
+// Expectation about the error : cardNumber is assigned a number value, a .slice function does not work on number
+// The constant last4Digits should be assigned to a String (cardNumber) to perform .slice function.


Your prediction is clear. What happened when you ran it? Did it match your prediction?

The prep shows three error names: SyntaxError, TypeError and ReferenceError. Which one did you get?

My very initial prediction was a last 4 card digit outcome; followed by a second glance and notice the code would result a TypeError.

TypeError is right. Please write it in the file too, below your prediction on line 8. Did it match your prediction?

Wrote the TypeError below my prediction line 8. Prediction matches.

Done. Line 9 has it now.

abdishakoor-dev · 2026-09-22T10:11:58Z

-const 24hourClockTime = "20:53";
+// const 12HourClockTime = "8:53pm";
+// const 24hourClockTime = "20:53";
+ // An identifier cannot start with a numberical value


Right reason. The prep shows three error names: SyntaxError, TypeError and ReferenceError. Which one is this?

It was a SyntaxError.

SyntaxError is right. Please add it to your comment on line 1 too.

Thanks. Change is saved, staged, and committed.

Done. Line 1 has it now.

abdishakoor-dev · 2026-09-22T10:11:58Z

+// Read the code and then answer the questions below
+
+// a) How many function calls are there in this file? Write down all the lines where a function call is made
+// There are five function calls in this code in lines 4, 5, and 10


Your answers use the line numbers of the original file. Your file has two extra lines now. The fixed line is on line 7, and console.log is on line 12. Delete line 5 and the empty line after it. Then check your line numbers in a) to d) again.

Line adjusted. Answers in a) to d) now correspond to the right lines.

The line numbers are right now.

abdishakoor-dev · 2026-09-22T10:11:58Z

+// On lines 7 and 8, variables priceDifference and percentageChange are declared by const.
+
+// e) Describe what the expression Number(carPrice.replaceAll(",","")) is doing - what is the purpose of this expression?
+// To remove comma as a punctuation and space such that the  string is ready turn into a number by method Number.


Does this remove spaces too? Look at the first argument of replaceAll.

No. replaceall("," , "") does not removes spaces. The 2nd argument is to replace each match with and empty string. Comment in code corrected accordingly - not mentioning remove spaces.

Right. Line 33 is correct now.

abdishakoor-dev · 2026-09-22T10:11:58Z

+// The variable result represents length of movie in H:M:S format. A better variable name can be movieLength_HMS  
+
+// f) Try experimenting with different values of movieLength. Will this code work for all values of movieLength? Explain your answer
+// A value of movieLength 3661 will return a result of 1:1:1 where the place value for second does not conforms with leading zero time format.


Good, the missing zeros are one problem. Now try -90 and 90.5. What does each one print? Would you show a time that way?

const movieLength = -90 prints "0:-1:-30" and const movieLength = -90.5 prints "0:-1:-30.5"

The code does not work for all values:
It does not pad single digits with a leading zero;
It does not validate to reject negative or decimal input.

Good. f) is complete now.

abdishakoor-dev · 2026-09-22T10:11:58Z

+
+const pence = paddedPenceNumberString
+  .substring(paddedPenceNumberString.length - 2)
+  .padEnd(2, "0"); // declares variable for pence. Argument -2 of .substring method returns the last two characters.


The argument here is paddedPenceNumberString.length - 2, not -2. What number is that for "399"?

Copy that. For "399" length of 3 characters, .substring (paddedPenceNumberString.length - 2)' returns substring(1)` . Given zero indexing, therefore should return "99"

Right, substring(1) gives "99". Lines 17 to 19 explain it well.

… 8 and 9, 4.js lines 1 and 2, and 1-percentage-change.js line 5.

…ime-format.js

abdishakoor-dev

Nearly there. Your answers in 1-percentage-change.js are all right now, and your answer to f) in 2-time-format.js is very thorough.

Three small things before I can mark this Complete:

3-to-pounds.js line 1: the p is missing from "399p" now. See my comment.
3.js and 4.js: you named the error in your replies. Please write it in the files too. Your answers should live in the files.
Line endings, from my last review. Your formatting is right now, thanks. But 13 of your 14 files still use Windows line endings (CRLF), so GitHub still shows every line as changed. Format Document does not change line endings. Instead, open each file in VS Code, click CRLF in the blue bar at the bottom right, choose LF, and save. 1-count.js is already right.

Add the Needs Review label again once you have pushed.

abdishakoor-dev · 2026-09-23T16:22:43Z

-
-// To begin, we can start with
-// 1. const penceString = "399p": initialises a string variable with the value "399p"
+const penceString = "399"; // initialises a string variable with the value "399p"


Line 1 was "399p" before. Now it is "399", without the p. I think this changed by accident. Run the file. It prints £0.39, not £3.99. Please put the p back.

Thanks for reminder. Saved the change, staged, and committed the file.

Fixed. It prints £3.99 again.

… applied

abdishakoor-dev

All three fixed, thanks. 3-to-pounds.js prints £3.99 again, and the error names are in 3.js and 4.js.

One last thing. 2-initials.js still has Windows line endings (CRLF). It is the only file left. Open it in VS Code, click CRLF in the blue bar at the bottom right, choose LF, and save.

Add the Needs Review label again once you have pushed, and I will mark this Complete.

abdishakoor-dev

All fixed. Every file uses LF now, Prettier passes, and every file runs. Marking this Complete. Well done.

Two things for your next PRs. You don't need to change anything here:

Variable names in JavaScript use camelCase, starting with a small letter. So in 4.js, twelveHourClockTime, not TweleveHourClockTime. Check the spelling of "twelve" too.
You asked on Slack how to stop CRLF coming back. There are two settings:
- In VS Code, press Ctrl + , and search for eol. Change Files: Eol from auto to \n. New files will then use LF. (The Prettier setting you ticked only chooses the formatter. It does not change line endings.)
- In the terminal, run this once: git config --global core.autocrlf input. Git will then change CRLF to LF every time you commit.
Please don't add a .gitattributes file to your coursework branch. It would be an extra file outside the Sprint-2 folder, so it would show in your PR. The two settings above fix it on your computer for every repo.

AlanGit-debug2604 and others added 9 commits September 21, 2026 16:48

modified Key exercises files 1,2,and3

42df165

Answer modified in 4-random.js

09045cf

Answered 1-percentage-change.js

ffaed93

Debugged the problem of 1-percentage-change.js- a comma is placed bet…

c504786

…weeen arguments

Answered 2-time-format.js

430be1d

Answered 3-to-pound.js

0fc5678

minor format change in 2-time-format.js

83a6fa1

Answered and reflected in chrome.md and object.md

0688923

Complete 2-mandatory -error from class

5bd8824

AlanGit-debug2604 added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Sep 21, 2026

abdishakoor-dev reviewed Sep 22, 2026

View reviewed changes

abdishakoor-dev added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Sep 22, 2026

debug2604 added 8 commits September 22, 2026 16:09

Answer 1-count.js: describe line 3 and assignment operator

8085ffc

Answer 4-random.js: describe what num represents, min and max

71e9cc8

Add specific error names to 2.js; clarify let vs const in 2.s

2d0acdc

Delete the old code you commented out: 1.js lines 6 and 7, 2.js lines…

1e725d9

… 8 and 9, 4.js lines 1 and 2, and 1-percentage-change.js line 5.

Line adjusted. Answers in a) to d) now correspond to the right lines.

bfd04f3

Answer f) with multiple test values including negative/decimal in 2-t…

f0d0c8b

…ime-format.js

Correct substring argument explanation in 3-to-pounds.js

b9108fd

Apply Prettier formatting and fix line endings across all files

df783e8

AlanGit-debug2604 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 23, 2026

abdishakoor-dev reviewed Sep 23, 2026

View reviewed changes

abdishakoor-dev removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 23, 2026

debug2604 added 4 commits September 23, 2026 17:32

put the trailingP back to line one in variable

2ba7e15

Wrote the TypeError on line 8

5d16528

Wrote the TypeError below my prediction line 8. Also ensured Prettier…

dc9d08d

… applied

Wrote the TypeError below my prediction line 8. Prediction matches.

f2cbb98

debug2604 added 2 commits September 23, 2026 17:49

Added SyntaxError on line 1

9712617

Convert remaining files from CRLF to LF line endings

5cc5f90

AlanGit-debug2604 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 23, 2026

abdishakoor-dev reviewed Sep 24, 2026

View reviewed changes

abdishakoor-dev removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 24, 2026

fix CRLF to LF

92182be

AlanGit-debug2604 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 24, 2026

abdishakoor-dev reviewed Sep 24, 2026

View reviewed changes

Uh oh!

Conversation

AlanGit-debug2604 commented Sep 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify Bot commented Sep 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for cyf-onboarding-module ready!

Uh oh!

abdishakoor-dev left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

abdishakoor-dev left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

abdishakoor-dev left a comment

Choose a reason for hiding this comment

Uh oh!

AlanGit-debug2604 commented Sep 21, 2026 •

edited

Loading

netlify Bot commented Sep 21, 2026 •

edited

Loading