Skip to content

London | 26-ITP-May | Risikat Popoola| Sprint 1|Coursework#1338

Closed
risikatpopoola wants to merge 6 commits into
CodeYourFuture:mainfrom
risikatpopoola:coursework/sprint1
Closed

London | 26-ITP-May | Risikat Popoola| Sprint 1|Coursework#1338
risikatpopoola wants to merge 6 commits into
CodeYourFuture:mainfrom
risikatpopoola:coursework/sprint1

Conversation

@risikatpopoola

@risikatpopoola risikatpopoola commented Jun 15, 2026

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

This PR includes various javascript exercises

@risikatpopoola risikatpopoola added 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Structuring-And-Testing-Data The name of the module. labels Jun 15, 2026
@risikatpopoola risikatpopoola changed the title London | 25-ITP-May | Risikat Popoola| Sprint 1|Structuring and Testing Data London | 25-ITP-May | Risikat Popoola| Sprint 1|Coursework Jun 15, 2026
@risikatpopoola risikatpopoola changed the title London | 25-ITP-May | Risikat Popoola| Sprint 1|Coursework London | 26-ITP-May | Risikat Popoola| Sprint 1|Coursework Jun 15, 2026
LonMcGregor
LonMcGregor reviewed Jun 19, 2026
View reviewed changes

@LonMcGregor LonMcGregor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, some changes needed, see my comments.

Good work doing the stretch tasks!

Comment thread Sprint-1/3-mandatory-interpret/1-percentage-change.js Outdated
// a) How many function calls are there in this file? Write down all the lines where a function call is made
//The function call are made twice
//line 4, 5,

@LonMcGregor LonMcGregor Jun 19, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work finding these, I think there are more function calls to find

Comment thread Sprint-1/3-mandatory-interpret/1-percentage-change.js
// d) Identify all the lines that are variable declarations

//Lines 1 & 2
// e) Describe what the expression Number(carPrice.replaceAll(",","")) is doing - what is the purpose of this expression?

@LonMcGregor LonMcGregor Jun 19, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you answer this last point?

Comment thread Sprint-1/3-mandatory-interpret/2-time-format.js Outdated

// e) What do you think the variable result represents? Can you think of a better name for this variable?

//The variable result represents the total time of the movie, in hours minutes and seconds.

@LonMcGregor LonMcGregor Jun 19, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you think of a better name?

Comment thread Sprint-1/3-mandatory-interpret/2-time-format.js
@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 19, 2026
@risikatpopoola risikatpopoola added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jul 1, 2026
@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Sprint-1/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 1, 2026
@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Sprint-1/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@risikatpopoola risikatpopoola added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 1, 2026
@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Sprint-1/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 1, 2026
risikatpopoola
risikatpopoola commented Jul 1, 2026
View reviewed changes

@risikatpopoola risikatpopoola left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new files

@risikatpopoola risikatpopoola added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 1, 2026
@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Sprint-1/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 1, 2026
@risikatpopoola risikatpopoola reopened this Jul 1, 2026
@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Sprint-1/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@risikatpopoola risikatpopoola deleted the coursework/sprint1 branch July 1, 2026 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LonMcGregor LonMcGregor LonMcGregor left review comments

Assignees

No one assigned

Labels

Module-Structuring-And-Testing-Data The name of the module. 📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@risikatpopoola @LonMcGregor