Skip to content

West Midlands | 26-May-ITP | Alina Sofragiu | Sprint 1 | Coursework#1342

Open
sofragiualina wants to merge 1 commit into
CodeYourFuture:mainfrom
sofragiualina:coursework/sprint-1
Open

West Midlands | 26-May-ITP | Alina Sofragiu | Sprint 1 | Coursework#1342
sofragiualina wants to merge 1 commit into
CodeYourFuture:mainfrom
sofragiualina:coursework/sprint-1

Conversation

@sofragiualina

@sofragiualina sofragiualina commented Jun 15, 2026

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • [ x ] I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • [ x ] My changes meet the requirements of the task
  • [ x ] I have tested my changes
  • [ x ] My changes follow the style guide

Changelist

Completed JavaScript exercises with explanations and comments added throughout the code to improve understanding.

@sofragiualina sofragiualina added 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Structuring-And-Testing-Data The name of the module. labels Jun 15, 2026
LonMcGregor
LonMcGregor reviewed Jun 22, 2026
View reviewed changes

@LonMcGregor LonMcGregor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work on this task, lots of good explanations. There's one task where I left a comment for you to review

Comment thread Sprint-1/3-mandatory-interpret/2-time-format.js
//It removes the extra seconds first, then divides by 60 to get complete minutes
// e) What do you think the variable result represents? Can you think of a better name for this variable?

//The movie length formatted as hours:minutes:seconds a better name could be movieTime

@LonMcGregor LonMcGregor Jun 22, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it clear enough what the difference is between a "length" and a "time"?

@sofragiualina sofragiualina Jun 22, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a length is a duration, while a time is usually a specific point on a clock, so in that case movieTime isn't the best choice and i will think that movieDuration will be more suitable because it clearly describes that the variable represents how long the movie lasts.

@LonMcGregor LonMcGregor Jun 23, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it accurately describe the form of the data, e.g. which is in a particular format and which is just a number?

@sofragiualina sofragiualina Jun 23, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

describes what the value represents, but not its format

@LonMcGregor LonMcGregor Jun 23, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. That's fine, it's worth being aware of how things differ. E.g. some people may expect a duration to be formatted a particular way, others may think it is similar to time. But overall, this task is complete. Well done

@sofragiualina sofragiualina Jun 23, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your feedback

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 22, 2026
@sofragiualina sofragiualina added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 22, 2026
@LonMcGregor LonMcGregor removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 23, 2026
@sofragiualina sofragiualina added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 23, 2026
@LonMcGregor LonMcGregor added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jun 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LonMcGregor LonMcGregor LonMcGregor left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Structuring-And-Testing-Data The name of the module. 📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sofragiualina @LonMcGregor