London | 26-ITP-May | Bisrat Tesfay| Sprint 1 | Coursework by B3-Bisrat · Pull Request #1383 · CodeYourFuture/Module-Structuring-and-Testing-Data

B3-Bisrat · 2026-06-22T19:16:26Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

I have completed all the coursework/sprint one tasks.

Questions

Joshuafolorunsho

Lovely work over all.
Clear answers, good use of console.log to check your values.
Just a couple of small things to mull over.

Joshuafolorunsho · 2026-06-27T08:09:27Z

+// num creates a random whole number between 1-100 (inclusive).
 // Try breaking down the expression and using documentation to explain what it means
+//maximum-minimum+1 gives us the number of possible values (100-1+1 = 100)
+//Math.random() gives us a random decimal number between 0 (inclusive) and 1 (exclusive)
+//Multiplying Math.random() by 100 gives us a random decimal number between 0 and 100 (exclusive)
+//Math.floor() rounds down the random decimal number to the nearest whole number.
+//Adding minimum to the result gives us a random whole number between minimum and maximum (inclusive)


I really like how you explained this bit.

Joshuafolorunsho · 2026-06-27T16:31:52Z

-const 24hourClockTime = "20:53";
+const twelveHourClockTime = "8:53pm";
+const twentyFourHourClockTime = "20:53";
+//variables can't start with a number. To fix this, we need to change the variable name to something that starts with a letter or an underscore.


Brilliant! Just out of curiosity, If you start with a dollar sign ($), would this error out as well?

No, in JavaScript variables can start with sign ($). I didn't know about this, thank you for letting me find out.

Joshuafolorunsho · 2026-06-27T16:39:20Z

+// Line 4 and line 5 are variable reassignment statements. In line 4, carPrice is being reassigned with the new value after removing the comma and converting it to a number. In line 5, priceAfterOneYear is being reassigned in the same way.

 // d) Identify all the lines that are variable declarations
+// Line 1 and line 2 are variable declarations. In line 1, carPrice is declared and initialized with the string value "10,000". In line 2, priceAfterOneYear is declared and initialized with the string value "8,543".


Good answer for lines 1 and 2, but have another scan through the whole file: are there any other lines that also declare a new variable with const or let?

Sorry, line 7 and 8 as well.

Joshuafolorunsho · 2026-06-27T16:58:47Z

You might have missed this question.

It is done now, thank you.

Joshuafolorunsho · 2026-06-27T16:59:12Z

You might have missed this question.

It is done now, thank you

Joshuafolorunsho · 2026-06-30T08:47:55Z

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Sprint-1/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

Hi @B3-Bisrat,

Could you please fix the problem here so I can re-review?

Thank you.

Joshuafolorunsho · 2026-07-01T07:33:12Z

Well done @B3-Bisrat !

B3-Bisrat added 4 commits June 17, 2026 07:16

1-key-exercises are done.

987c2ce

2-mandatory-errors are done.

647ad66

3-mandatory-interpret are done.

d2baabe

4-strech-explore are done.

fa849fa

This comment has been minimized.

Sign in to view

B3-Bisrat added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 22, 2026

This comment has been minimized.

Sign in to view

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 22, 2026

B3-Bisrat added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 22, 2026

Joshuafolorunsho added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Jun 27, 2026

Joshuafolorunsho reviewed Jun 27, 2026

View reviewed changes

Joshuafolorunsho added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jun 27, 2026

B3-Bisrat removed the Reviewed Volunteer to add when completing a review with trainee action still to take. label Jun 29, 2026

This comment has been minimized.

Sign in to view

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 29, 2026

B3-Bisrat force-pushed the coursework/sprint-1 branch from aab0047 to fa849fa Compare June 30, 2026 19:24

Problems are fixed.

bc89c41

B3-Bisrat added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 30, 2026

Joshuafolorunsho added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 1, 2026

Uh oh!

Uh oh!

Conversation

B3-Bisrat commented Jun 22, 2026

Learners, PR Template

Changelist

Questions

Uh oh!

This comment has been minimized.

This comment has been minimized.

Joshuafolorunsho left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

Joshuafolorunsho commented Jun 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Joshuafolorunsho commented Jul 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Joshuafolorunsho commented Jun 30, 2026 •

edited

Loading