Glasgow | 26-ITP-May | Niangh Ciang | Sprint 3 | Implement and rewrite tests#1401
Open
Niangh-Ciang wants to merge 7 commits into
Open
Conversation
Niangh-Ciang
added
📅 Sprint 3
LonMcGregor
reviewed
Jul 1, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Very good work on these. It's just your fractions implementation that needs another update
|
|
||
| function isProperFraction(numerator, denominator) { | ||
| // TODO: Implement this function | ||
| if (numerator > 0 && denominator > 0 && numerator < denominator) { |
There was a problem hiding this comment.
Could this function be simplified? (Hint: your are returning true/false from an if condition)
| assertEquals(isProperFraction(1, 2), true); | ||
| assertEquals(isProperFraction(5, 10), true); | ||
| assertEquals(isProperFraction(2, 3), true); | ||
| assertEquals(isProperFraction(-2, 4), false); |
There was a problem hiding this comment.
-2/4 is actually a proper fraction. Can you check your test and implementation to see how to resolve this?
| expect(isProperFraction(1, 2)).toEqual(true); | ||
| expect(isProperFraction(3, 5)).toEqual(true); | ||
| }); | ||
| test("should return false when numerator is negative", () => { |
There was a problem hiding this comment.
See also my remark above. Fractions can have a negative numerator and still be valid proper fractions.
LonMcGregor
added
Reviewed
Author
|
Hello, I have fixed the proper fraction logic. |
Niangh-Ciang
added
Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
Implemented all three functions and rewrote their test suites using Jest.
Covered all required cases including valid, boundary, and invalid inputs.