Skip to content

London | 26-ITP-May | Tomislav Dukez | Sprint 1 | Coursework#1412

Open
tomdu3 wants to merge 15 commits into
CodeYourFuture:mainfrom
tomdu3:coursework/sprint-1
Open

London | 26-ITP-May | Tomislav Dukez | Sprint 1 | Coursework#1412
tomdu3 wants to merge 15 commits into
CodeYourFuture:mainfrom
tomdu3:coursework/sprint-1

Conversation

@tomdu3

@tomdu3 tomdu3 commented Jun 27, 2026

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Coursework exercises for Sprint 1 of Module Structuring and Testing Data.

@tomdu3 tomdu3 added 🏕 Priority Mandatory This work is expected 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Structuring-And-Testing-Data The name of the module. labels Jun 27, 2026
@LonMcGregor LonMcGregor added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Jun 30, 2026
LonMcGregor
LonMcGregor reviewed Jun 30, 2026
View reviewed changes

@LonMcGregor LonMcGregor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work on this so far. Good exploration of the stretch tasks. I have left some comments for you to resolve

Comment thread Sprint-1/1-key-exercises/1-count.js
Comment thread Sprint-1/3-mandatory-interpret/2-time-format.js Outdated
Comment thread Sprint-1/3-mandatory-interpret/2-time-format.js Outdated
Comment thread Sprint-1/3-mandatory-interpret/1-percentage-change.js
@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jun 30, 2026
@tomdu3 tomdu3 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jun 30, 2026
LonMcGregor
LonMcGregor reviewed Jul 1, 2026
View reviewed changes

@LonMcGregor LonMcGregor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! You found the functions, and clarifying that it is formatted in the variable name makes it much clearer what the difference is. Task complete.

@LonMcGregor LonMcGregor added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 1, 2026
@tomdu3

tomdu3 commented Jul 1, 2026

Copy link
Copy Markdown
Author

Thank you very much for the review and guidance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LonMcGregor LonMcGregor LonMcGregor left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Structuring-And-Testing-Data The name of the module. 🏕 Priority Mandatory This work is expected 📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tomdu3 @LonMcGregor