Update assignments for module rework - #1625
illicitonion wants to merge 2 commits into
Conversation
This: * Pulls implement-and-rewrite out of the per-sprint folder, and will assign it for sprint 2 * Updates implement-and-rewrite to use node:test and then rewrite to jest * Pulls practice-tdd out of the per-sprint folder, and will assign it to sprint 2 * Updates everything from require to import * Deletes the rest of the Sprint-2 folder because they're unused/unreferenced. We can recover them from git history if we need, but they are no longer relevant to this module. * Leaves the rest of Sprint-1 and Sprint-3 in place, but they're not assigned as work anywhere (except Sprint-3/3-dead-code). We can delete these if we think it's confusing - I'm 50:50 on it...
This comment has been minimized.
This comment has been minimized.
| * For `node:test` tests, you can run them in the terminal with `node path/to/file`. | ||
| * To run all of the tests in this repo, you can run `npm test`. | ||
| * To run just one directory or file of tests, you can run `npm test implement-and-rewrite-tests/rewrite-tests-with-jest` or `implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js`. | ||
| * VSCode has a built-in test runner that you can use to run the tests, and this should make it much easier to focus on building up your test cases one at a time. |
There was a problem hiding this comment.
VSCode has a built-in test runner...
Not actually built-in AFAIK - I just had to enable a Jest extension in order to have the option for running individual tests appear in the VS Code GUI.
As an aside, I don't personally love this option. It can lead to people exclusively running tests individually and never running them as a whole, which can lead to issues not being caught. Specifically, when someone has accidentally written tests that are not independent but hasn't seen that play out because they've only run them in isolation. What do you think?
There was a problem hiding this comment.
Not actually built-in AFAIK - I just had to enable a Jest extension in order to use VS Code's GUI to run the tests rather than the command line.
Can you suggest an edit to discuss installing/enabling the extension? :)
As an aside, I don't personally love this option. It can lead to people exclusively running tests individually and never running them as a whole, which can lead to issues if someone has not made their tests independent without realising that could be a problem. What do you think?
Let's maybe add a prep item about this, where we can give a sample repo and show people the trade-offs/limitations here?
There's a tricky balance thing here where because the project is whole-repo-scoped, if you just npm test you end up running (and failing) the tests from all of the exercises you haven't actually done. So realistically in this repo the two options are npm test path/to/dir (fiddly to type, or to switch tests) or using the in-IDE integration (with the issues you raise)...
|
Looks good! To respond to some of your overall points:
This is fine, I think in an ideal world we'd have an archive of tasks we don't use any more, because whilst they are technically still available in git history, it'd be very easy to forget that they exist entirely and awkward to search for them if we do remember. I would say leave them as is here (deleted) and I'll add "create archive" to my to-do list 🙂
Let me know what you think! |
rm -rf Sprint-1 mv Sprint-3/3-dead-code dead-code mv Sprint-3/4-stretch sprint-3-stretch-exercises
Thanks! 👍
Makes sense - done! I moved stretch to sprint-3-stretch-exercises because I think realistically if we end up with more stretch exercises we probably want to group them somehow. |
2 participants
This: