ZA | 25-SDC-Nov | Rashaad Ebrahim | Sprint 4 | Implement Shell Tools (Python)#276
Closed
Rashaad-Ebrahim wants to merge 13 commits into
Closed
ZA | 25-SDC-Nov | Rashaad Ebrahim | Sprint 4 | Implement Shell Tools (Python)#276Rashaad-Ebrahim wants to merge 13 commits into
Rashaad-Ebrahim wants to merge 13 commits into
Conversation
Totals saved as an object just like the file details so we can format the output easily
Rashaad-Ebrahim
added
the
Needs Review
LonMcGregor
added
Review in progress
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
LonMcGregor
reviewed
Jan 7, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
Contributor
There was a problem hiding this comment.
Good implementations, well done. I just have one comment asking about your gitignore file
| @@ -1 +1,3 @@ | |||
| node_modules | |||
| **/.venv | |||
| **/requirements.txt | |||
Contributor
There was a problem hiding this comment.
Do you know what the requirements file is for? what would the side effect be of adding it to the ignore file?
Author
There was a problem hiding this comment.
**/requirements.txt removed from the gitignore file.
I was previously advised about why the requirement.txt should not be in the gitignore. I understand that the details in the file are required so that the person who clones the repository has the same setup as I did
Contributor
There was a problem hiding this comment.
Correct! This PR now looks complete
LonMcGregor
added
Reviewed
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
Rashaad-Ebrahim
added
Needs Review
LonMcGregor
added
Complete
Member
|
Closing PR because the SDC run has finished. Feel free to re-open if you're still working on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
My Python implementations of the the Unix commands cat, ls and wc.
Questions
No questions at this time