Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the frame rate limiting algorithm. Previously, the frame rate limit was not very stable; this change makes the limited frame rate more stable. A typical scenario is that previously, limiting to 1000 FPS would actually fluctuate between 800 and 900. With this change, it can be stably limited to 1000. Frame rate limits such as 60, 120, 144, and 160 will also be more stable than before.
The specific reason is that the previously used SDL_DelayPrecise operation had some wake-up latency, causing the actual frame rate to be unstable. The new approach uses busy-waiting for the last 1.5 milliseconds to eliminate that latency.