Skip to content

feat: make problem construction model-owned - #1134

Merged
isPANN merged 1 commit into
codex/dynamic-create-schemafrom
codex/model-owned-construction
Aug 11, 2026
Merged

feat: make problem construction model-owned#1134
isPANN merged 1 commit into
codex/dynamic-create-schemafrom
codex/model-owned-construction

Conversation

@isPANN

@isPANN isPANN commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

Closes #1133

Stacked on #1132. Review this PR against codex/dynamic-create-schema.

What changed

  • Added a model-owned CreateSpec contract with derived static input metadata, reusable codecs, strict unknown/missing-input errors, and type-erased construction callbacks on VariantEntry.
  • Kept ordinary models zero-boilerplate while moving exceptional construction, derived fields, defaults, renames, composite graph inputs, and invariant checks beside their model types.
  • Made CLI and MCP resolve the concrete variant, normalize values from the registered contract, call the same constructor, and serialize the resulting typed problem.
  • Deleted the central schema semantics module and superseded model-name construction branches.
  • Made Clap numeric parsers follow the selected variant concrete type, including u64::MAX and arbitrary-precision integer inputs.
  • Updated add-model documentation and added catalog, CLI, MCP, model, and numeric-boundary regression coverage.

Random instance generation remains a separate existing capability; this PR replaces the non-random construction path.

Verification

  • cargo test --workspace --all-features
  • cargo clippy --workspace --all-targets --all-features -- -D warnings
  • cargo fmt --all -- --check
  • git diff --check
  • Manual SCS positive/derived-field negative checks
  • Manual ThreePartition u64::MAX construction check

@isPANN
isPANN merged commit 698303e into codex/dynamic-create-schema Aug 11, 2026
@isPANN
isPANN deleted the codex/model-owned-construction branch August 11, 2026 13:46
isPANN added a commit that referenced this pull request Aug 12, 2026
* refactor: build create arguments from schemas

* feat: move problem construction contracts into models (#1134)

* refactor: make random generation model-owned

* refactor: simplify registry-driven create

* Declare model categories explicitly (#1136)

* refactor: declare model categories explicitly

* refactor: preserve typed categories in graph export

* refactor: parse only selected create model

* fix: remove conflicting graph partitioning alias
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant