Multiple updates - #100
Open
thmarx wants to merge 13 commits into
Open
Conversation
Refactored SubmitFormHandler and AjaxSubmitFormHandler to correctly handle asynchronous form processing. The response logic is now executed within the Promise callbacks, ensuring that the response is sent only after the form processing is complete.
Fix Race Condition in Form Handlers
Documents the plan to adapt the copied video-module E2ETest/test-server to forms-module, fix the missing module-deploy step that leaves the CMS server with 0 loaded extensions, and make captcha optional per form so automated E2E tests don't need to solve captchas.
Breaks the design into five tasks: make captcha optional per form, fix the module-deploy gap that leaves the CMS test server with 0 loaded extensions, rewrite test-server content for forms-module, rewrite the E2E suite with GreenMail-backed mail assertions, and finalize .gitignore.
Splits the single-module layout into a parent POM (dependency management) plus a module/ submodule, and adds the video-module-derived test-server/ and E2ETest.java scaffolding that the following commits will adapt to forms-module.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.