fix(quality): install PHPUnit sibling apps on the PHP the leg tests on - #779
Open
rubenvdlinde wants to merge 1 commit into
Open
rubenvdlinde wants to merge 1 commit into
rubenvdlinde wants to merge 1 commit into
Conversation
The PHPUnit job ran `composer install` for each additional app before Setup PHP, so a sibling's lock was checked against the runner image's system PHP instead of the matrix PHP. The newman, playwright and journeydoc-capture jobs already run Setup PHP first. On keepiq development (run 34948398659) the image's ext-redis 5.3.7 conflicted with symfony/cache v7.4.14 in integriq's lock, so all six PHPUnit cells failed before a test ran. integriq's own CI installs the same lock after Setup PHP and passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
In the
phpunitjob, Setup PHP now runs before Checkout additional apps. The step moved as-is, apart from one added comment explaining the order. Thenewman,playwrightandjourneydoc-capturejobs already use this order.Why
The sibling
composer installran on the runner image's system PHP, not the matrix PHP the leg tests on. The image loadsext-redis5.3.7, andsymfony/cachev7.4.14 in integriq's lock conflicts withext-redis <6.1:developmentthen failed at this step before running any test (run 34948398659). The parent commit was green.additional-apps: opencatalogi, launchpad, stackiq, zaakafhandelapp, dossiq, shillinq, learniq, portaliq, decidiq, buildiq and keepiq. They all take the same path.Blast radius
The change applies fleet-wide on merge, because callers resolve
@main. Sibling installs now run on the matrix PHP (8.3 and 8.4) with the PHPUnit extension list. That list is a superset of thenewmanjob's, andnewmanalready installs the same siblings after Setup PHP. The siblings in use are openregister, integriq, decidiq, planninq, thematiq, dossiq and filinq@main, and each runs its own 8.3/8.4 matrix.Verified
actionlint1.7.12 on the changed file: exit 0, no findings. The YAML parses, and thephpunitstep order now reads Checkout server, submodules, app, Setup PHP, Checkout additional apps, Install Nextcloud.uses:at this branch: https://github.com/ConductionNL/keepiq/actions/runs/34955589876. Result pending when this PR was opened; the PHPUnit cells should get past the sibling install.🤖 Generated with Claude Code