fix(deps): restore the dependency graph I broke on development - #603
Merged
rubenvdlinde merged 1 commit intoSep 10, 2026
Merged
Conversation
Two problems, both mine, both from admin-merging a dependabot batch without
resolving it first. `npm ci` on `development` exits 1, so every frontend job
would fail.
1. nc-vue 2.41.1 pins `peerOptional marked@^12.0.0` and launchpad carries
marked 18, so the graph cannot resolve:
Found: marked@18.0.12
Could not resolve: peerOptional marked@^12.0.0 from @conduction/nextcloud-vue@2.41.1
nc-vue widened that range to `>=12 <19` in 2.43.0, so taking 2.44.1 fixes it
rather than pinning marked back. dossiq already runs 2.44.1 with marked 18.
2. `@vitest/ui` went to ^5.0.0 alone. It peer-requires EXACTLY `vitest 5.0.0`
while vitest and @vitest/coverage-v8 stay ^4.1.11. That is a held major and I
merged it by mistake in a loop that only skipped conflicting PRs; restored to
^4.1.11 so the family is one version again.
Verified locally, by exit code, on a CLEAN tree:
rm -rf node_modules && npm ci -> 0
npm run build -> 0
npm run test -> 0 (64 files, 708 tests)
resolved: nc-vue 2.44.1 marked 18.0.12 vitest 4.1.11 @vitest/ui 4.1.11
The lock is updated in place rather than regenerated: deleting it makes npm fail
to resolve the `"pinia": "$pinia"` override.
Contributor
Quality Report — ConductionNL/launchpad @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| format | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 104/104 | |||
| npm | ✅ | ✅ 534/534 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ✅ | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-09-10 14:46 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm ciondevelopmentcurrently exits 1, so every frontend job would fail.Both causes are mine, from admin-merging a dependabot batch without resolving the
graph first.
1. nc-vue 2.41.1 cannot see marked 18
nc-vue widened that range to
>=12 <19in 2.43.0, so the fix is to take2.44.1 rather than pin marked back. dossiq already runs 2.44.1 with marked 18.
2.
@vitest/uimoved to 5 aloneIt peer-requires exactly
vitest@5.0.0, whilevitestand@vitest/coverage-v8stay^4.1.11. That is a held major and I merged it bymistake, in a loop that skipped only conflicting PRs. Restored to
^4.1.11sothe family is one version again. #593 and #596 stay open and held.
Verified locally, by exit code, on a clean tree
One note for the next person
The lock is updated in place, not regenerated. Deleting
package-lock.jsonmakesnpm installfail withUnable to resolve reference $pinia— theoverridesblock uses
"pinia": "$pinia", and that reference needs the existing lock.