feat(news): take ownership of the news widget from nc-vue - #615
Open
SudoThijn wants to merge 1 commit into
Open
Conversation
The renderer in nc-vue could not fetch a feed. It read a consumer-supplied `itemsEndpoint`, and LaunchPad was the only app that ever supplied one — so in every other app the form collected feed URLs that nothing could load, and the widget sat there empty with no error. The feed path is entirely ours already: NewsWidgetService, FeedRefreshService, the feed cache table and its background job. The widget belongs with them. LaunchPad already had its own `NewsWidget.vue` — 617 lines, still passing its spec, orphaned when the communal CnNewsWidget superseded it. Revived rather than porting a second copy: it calls our own endpoint directly. The form had no local equivalent, so CnNewsWidgetForm is ported as NewsWidgetForm, moved to the `launchpad` translation domain and to this repo's lint conventions. `news` is now registered in widgetRegistry.js alongside clock/weather, after the shared-catalog import so it replaces the communal entry while nc-vue still ships one. The content shape is unchanged, so placements authored against the communal form keep rendering. The `itemsEndpoint` injection in widgetDataAdapters.js is dropped — the renderer owns its endpoint now, and leaving it would bind an unused function onto the root element. Comments in WidgetRenderer and ContainerChild that described that seam updated with it.
Contributor
Quality Report — ConductionNL/launchpad @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| format | ❌ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 104/104 | |||
| npm | ✅ | ✅ 534/534 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ✅ | ||||
| Hydra gates | ❌ |
Quality workflow — 2026-09-11 12:58 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The renderer in nc-vue could not fetch a feed. It read a consumer-supplied
itemsEndpoint, and LaunchPad was the only app that ever supplied one — so inevery other app the form collected feed URLs that nothing could load, and the
widget sat there empty with no error. The feed path is entirely ours already:
NewsWidgetService, FeedRefreshService, the feed cache table and its background
job. The widget belongs with them.
LaunchPad already had its own
NewsWidget.vue— 617 lines, still passing itsspec, orphaned when the communal CnNewsWidget superseded it. Revived rather
than porting a second copy: it calls our own endpoint directly. The form had no
local equivalent, so CnNewsWidgetForm is ported as NewsWidgetForm, moved to the
launchpadtranslation domain and to this repo's lint conventions.newsis now registered in widgetRegistry.js alongside clock/weather, afterthe shared-catalog import so it replaces the communal entry while nc-vue still
ships one. The content shape is unchanged, so placements authored against the
communal form keep rendering.
The
itemsEndpointinjection in widgetDataAdapters.js is dropped — therenderer owns its endpoint now, and leaving it would bind an unused function
onto the root element. Comments in WidgetRenderer and ContainerChild that
described that seam updated with it.