Skip to content

feat(news): take ownership of the news widget from nc-vue - #615

Open
SudoThijn wants to merge 1 commit into
developmentfrom
feature/news-widget-rss
Open

feat(news): take ownership of the news widget from nc-vue#615
SudoThijn wants to merge 1 commit into
developmentfrom
feature/news-widget-rss

Conversation

@SudoThijn

Copy link
Copy Markdown
Contributor

The renderer in nc-vue could not fetch a feed. It read a consumer-supplied
itemsEndpoint, and LaunchPad was the only app that ever supplied one — so in
every other app the form collected feed URLs that nothing could load, and the
widget sat there empty with no error. The feed path is entirely ours already:
NewsWidgetService, FeedRefreshService, the feed cache table and its background
job. The widget belongs with them.

LaunchPad already had its own NewsWidget.vue — 617 lines, still passing its
spec, orphaned when the communal CnNewsWidget superseded it. Revived rather
than porting a second copy: it calls our own endpoint directly. The form had no
local equivalent, so CnNewsWidgetForm is ported as NewsWidgetForm, moved to the
launchpad translation domain and to this repo's lint conventions.

news is now registered in widgetRegistry.js alongside clock/weather, after
the shared-catalog import so it replaces the communal entry while nc-vue still
ships one. The content shape is unchanged, so placements authored against the
communal form keep rendering.

The itemsEndpoint injection in widgetDataAdapters.js is dropped — the
renderer owns its endpoint now, and leaving it would bind an unused function
onto the root element. Comments in WidgetRenderer and ContainerChild that
described that seam updated with it.

The renderer in nc-vue could not fetch a feed. It read a consumer-supplied
`itemsEndpoint`, and LaunchPad was the only app that ever supplied one — so in
every other app the form collected feed URLs that nothing could load, and the
widget sat there empty with no error. The feed path is entirely ours already:
NewsWidgetService, FeedRefreshService, the feed cache table and its background
job. The widget belongs with them.

LaunchPad already had its own `NewsWidget.vue` — 617 lines, still passing its
spec, orphaned when the communal CnNewsWidget superseded it. Revived rather
than porting a second copy: it calls our own endpoint directly. The form had no
local equivalent, so CnNewsWidgetForm is ported as NewsWidgetForm, moved to the
`launchpad` translation domain and to this repo's lint conventions.

`news` is now registered in widgetRegistry.js alongside clock/weather, after
the shared-catalog import so it replaces the communal entry while nc-vue still
ships one. The content shape is unchanged, so placements authored against the
communal form keep rendering.

The `itemsEndpoint` injection in widgetDataAdapters.js is dropped — the
renderer owns its endpoint now, and leaving it would bind an unused function
onto the root element. Comments in WidgetRenderer and ContainerChild that
described that seam updated with it.
@SudoThijn
SudoThijn requested a review from remko48 as a code owner September 11, 2026 12:34
@github-actions

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/launchpad @ 027ed4e

Check PHP Vue Security License Tests
lint
phpcs
phpmd
psalm
phpstan
phpmetrics
eslint
stylelint
build
check-manifest
format
check-schema-l10n
composer ✅ 104/104
npm ✅ 534/534
app:check-code ⏭️
info.xml
REUSE
PHPUnit
Newman
Playwright
Hydra gates

Quality workflow — 2026-09-11 12:58 UTC

Download the full PDF report from the workflow artifacts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant