feat(connections): an Integrations page over integriq's connection registry - #641
Merged
Merged
Conversation
…fresh after a registry save
…ames the tests that exist
…q in the CI instance
…at cannot see null
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
September 15, 2026 04:42
Contributor
Quality Report — ConductionNL/launchpad @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| format | ❌ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 104/104 | |||
| npm | ✅ | ✅ 534/534 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ | ||||
| Newman | ✅ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it on any branch from the Actions tab, or locally with npx playwright test. |
||||
| Hydra gates | ✅ |
Quality workflow — 2026-09-15 04:46 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LaunchPad now has an Integrations page under the settings gear. It lists LaunchPad's outside connections from integriq's connection registry (hydra#667, amended in hydra#673, hydra#674 and hydra#676).
Connections
dashboard-registryrequiredConfig: ["registry_url"], links to/settings/admin/launchpad?tab=sharing#section-dashboard-registryconfigured,unconfigured,limited,error, orunavailablewithout OpenRegister.weatherreportedOnlyunconfigured, a bad scheme or an unreadable answer readserror.news-feedsreportedOnly, one family row (D12)ics-calendarsreportedOnly, one family row (D12)live-tilesreportedOnly, one family row (D12)unconfigured.health-pingreportedOnly, one family row (D12)unconfigured.Weather. A placement without a location reads Nextcloud's weather status app for the viewer and never calls the provider URL. So an empty
weather_provider_urlis a working default for those widgets. It reads Not configured only after a widget with a location found no URL. A weather status reading is about one user and sends nothing.Why
StoreServicereports. It is the one caller of OpenRegister'sGenericStoreService, which calls the remote dashboard registry atregistry_urlwithregistry_token. It is also the one writer of those keys, so the refresh after a save goes there too.Application.phpbuilds it by hand, so the reporter is passed in there.Throttle. The report memory is one app-config value per connection. The same status reports again after an hour, a different status after five minutes. A registry save clears the registry's memory, so the next search reports at once. Every report runs after the call it observes, catches everything, and never changes the widget's answer. Without integriq nothing is read, stored, sent or logged.
What changed
lib/Settings/connections.json, valid against integriq'sconnections.schema.jsonfromdevelopment(vendored intests/Fixtures/Integriq/).id="section-dashboard-registry". The link adds?tab=sharingbecauseBeheerTabsrenders only the active tab.src/manifest.d/connection-registry.json: index page overintegriq/app_connection,requiresAppintegriq, admin only,showAdd: false. The menu entry carriesquery: {app: launchpad}andvisibleIf.appInstalled: integriq./apps/integriq/connections?app=launchpad&link=1through a handler insrc/customComponents.js.connectionStatusandconnectionSettingsLabelformatters, withlimited("Limited", "Beperkt"). The strings are in English and Dutch.ConnectionReporterandConnectionObservations. Events are named by string constant behindclass_exists. A save sends the refresh first, and the report follows.StoreService,WeatherService,NewsWidgetService,CalendarWidgetService,LiveTileServiceandHealthPingService.tests/Stubs/Integriq/, loaded bytests/bootstrap.phpand declared inpsalm.xml.tests/e2e/integrations-page.spec.ts, and CI installs integriq throughadditional-apps.Contract misfits
"",false,0andnullas empty, not[]. A fail-closed list that allows nothing would read Configured, so it cannot berequiredConfig. A report after a refusal says it instead.occonly. They carry nosettingsUrl, and their messages name the key.reportedOnlyplus reports is the closest fit.occsends no refresh. Integriq's hourly resolver pass covers it.Verified
openspec validate adopt-connection-registry --strict: valid.development(the vendored copy matches it byte for byte after formatting). The gate-116 checker, run by hand against that schema, reports 0 findings.send()sits inside a second catch-all.diff-check.sh --base origin/development) atc934e99: exit 0, GREEN. 0 NEW findings from gates, php -l, phpcs, phpstan, phpunit, eslint and stylelint.COMPOSER_PROCESS_TIMEOUT=0 composer check:strictatc934e99: exit 0, "ALL CHECKS PASSED". PHPUnit 1,756 tests, 4,748 assertions, 12 skipped. Psalm and PHPStan: no errors.npm run lint: exit 0.connectionRegistry.spec.js: 12 passed.Not verified
Inherited findings
check:strict: 681 warnings for missing@spectags on classes this change does not touch. No errors.RoleFeaturePermissionServiceandPermissionServiceare app-local permission services.integriqis not in LaunchPad's register JSON. That is expected for a page over another app's register.openspec/specs/, so the new change spec's@e2etags were not checked by the gate.conduction/hydra-gates, so I ran its checker by hand (see Verified).🤖 Generated with Claude Code