test: declare the classes these tests use, so the PHPUnit cells stop failing - #646
Merged
rubenvdlinde merged 1 commit intoSep 16, 2026
Conversation
…failing The suite sets failOnRisky with beStrictAboutCoverageMetadata, so a test that touches a class named in neither @Covers nor @uses is reported risky and the run exits non-zero. PHPUnit still prints "OK, but there were issues!", which is why this reads as a pass in the log while the cell is red. These classes were already being exercised; only the annotation was missing.
rubenvdlinde
requested review from
WilcoLouwerse,
bbrands02 and
rjzondervan
as code owners
September 16, 2026 07:16
Contributor
Quality Report — ConductionNL/launchpad @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| format | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 104/104 | |||
| npm | ✅ | ✅ 534/534 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it on any branch from the Actions tab, or locally with npx playwright test. |
||||
| Hydra gates | ✅ |
Quality workflow — 2026-09-16 07:25 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Adds the missing
@usesannotations to the connection report tests, which is the last thing keeping the PHPUnit cells red on development.Why the cells were red when the log said OK
The suite sets
failOnRisky="true"together withbeStrictAboutCoverageMetadata="true". A test that executes a class named in neither@coversnor@usesis reported risky, and PHPUnit then exits non-zero. It still printsOK, but there were issues!first, so the log reads like a pass while the cell is red. That is worth knowing, because the summary line is not the thing to trust here.Nothing about the tests changes. These classes were already being exercised; only the declaration was missing.
Verified locally
php -landphpcsclean on every touched filecomposer check:strictrun once@usesname was resolved through the app autoloader, so none of them is a typo that would silently fail to suppress the findingThe risky check itself needs a coverage driver, and this machine has neither xdebug nor pcov, so the count going to zero is the one thing I could not reproduce locally. CI is the arbiter for that.
🤖 Generated with Claude Code