chore(deps): take nextcloud-vue 3.2.0 and drop the local connection formatters - #648
Merged
Merged
Conversation
Drops LaunchPad's local connectionStatus and connectionSettingsLabel copy and the formatters prop that passed it to CnAppRoot. The spec now builds the registry the way CnAppRoot does and asks it for a switched-off connection.
…nnection formatters
…-connection-formatters # Conflicts: # src/App.vue # src/services/__tests__/connectionRegistry.spec.js # src/services/connectionRegistry.js
Contributor
Quality Report — ConductionNL/launchpad @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| format | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 104/104 | |||
| npm | ✅ | ✅ 636/636 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it on any branch from the Actions tab, or locally with npx playwright test. |
||||
| Hydra gates | ✅ |
Quality workflow — 2026-09-16 10:04 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LaunchPad now takes
@conduction/nextcloud-vue3.2.0, which ships the Integrations page's two formatters as built-ins. The local copies are gone. A connection an admin switched off now reads "Switched off" instead of the raw worddisabled.Part of hydra#677 (connection-registry design D8). The library side is nextcloud-vue#1173, released through #1175.
Version
@conduction/nextcloud-vue^2.46.0(lockfile 2.46.0) to^3.2.0(lockfile 3.2.0).npm ls --depth=0exits 0.marked,dompurify,dexieandgridstackare declared independencies.@vueuse/coreis not a direct dependency. Theoverridesblock pins it to^14.0.0, and it resolves to one copy, 14.4.0.What changed
src/services/connectionRegistry.jskeeps only the Add integration handler.CONNECTION_STATUS_LABELSandcreateConnectionFormattersare deleted.src/App.vueno longer passes:formatterstoCnAppRoot.src/services/__tests__/connectionRegistry.spec.js: the tests that only covered the local copy are removed. One test builds the registry the wayCnAppRootdoes ({ ...BUILT_IN_FORMATTERS, ...formatters }) and expectsconnectionStatus('disabled')to be "Switched off". The column name check resolves against that same registry.Mutation check. On the committed code I put back development's
connectionRegistry.jsandApp.vue, the six-status copy wired intoCnAppRoot. The new test went red on its assertion line:expected 'disabled' to be 'Switched off', spec line 46. Restored,git statusclean, green again.What 3.x touches here
CnNewsWidget,CnNewsWidgetFormand thenewstype. LaunchPad already registers its own on development (5a99701a, "take ownership of the news widget from nc-vue").src/constants/widgetRegistry.jsregistersnewswithNewsWidget.vueandNewsWidgetForm.vue, and nothing imports the removed exports. Storednewsplacements keep a renderer.TileWidget.vue, which falls back to#0082c9, so they are unchanged. Registrytileplacements render throughCnDashTileWidget, which in 3.2.0 still falls back to#3b82f6. The untinted path isCnTileWidgetinsideCnDashboardPage, and no LaunchPad dashboard page declares atilewidget.headerActionsmove into the Actions menu. LaunchPad has no detail page withheaderActions. The oneheaderActionsentry sits on the Integrations index page, which already used the menu.navigateactions now open as links. No LaunchPad action navigates to an external URL.index.js.@nextcloud/files^4.0.0. LaunchPad imports nothing from@nextcloud/files. See "Not verified".Verification
npm run build: exit 0, with the two existing asset size warnings.npm run lint: exit 0. The first run had one error from this branch (import order in the spec), fixed in7c17e55d.npx vitest run: exit 1 on the first run, 741 of 748 passing. All seven failures were timeouts inbeforeEachhooks or module imports, with the machine at load 40 to 70. The six files rerun on their own: exit 0, 35 of 35. None of them touches a formatter.hydra/scripts/diff-check.sh --base origin/developmentwithHYDRA_GATES_HOMEon the vendored gates: exit 0, GREEN. Gates, phpunit, eslint and stylelint report 0 new and 0 inherited findings.COMPOSER_PROCESS_TIMEOUT=0 composer check:strict(per-laneTMPDIRandHOME): exit 0, "ALL CHECKS PASSED", PHPUnit 1756 tests, 12 skipped.Not verified
occ. I did not see the Integrations page or a dashboard render with 3.2.0.newsplacement. The claim above rests on the registration inwidgetRegistry.jsand its unit specs.@nextcloud/files4.0.0 was not exercised.Inherited
None on the lines this PR touches. The webpack asset size warnings predate this change.
🤖 Generated with Claude Code