add generic fallback if the WidgetFontStyle name is unknown - #3934
Merged
Merged
Conversation
georgweiss
approved these changes
Sep 22, 2026
georgweiss
left a comment
georgweiss
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, but maybe the debug log should include the name argument, e.g.
log(Level.WARNING, "Cannot find WidgetFontStyle " + name, e)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a display where a widget has selected one of the new styles is loaded into a version of Phoebus where this is not supported, the editor will show an error dialog and the widget will be highlighted. To avoid this issue, a generic fallback has been added to check if the WidgetFontStyle name is unknown.
This PR will help adding the new underline style in the future (#3927)
Checklist