Skip to content

Add safe cstring rules #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nunoplopes merged 11 commits into from
Jul 18, 2026
Merged

Add safe cstring rules #250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
f6b6eeb
Add safe rules for cstring
lucic71 Jul 7, 2026
a870f5c
Fix strdup argument passing
lucic71 Jul 7, 2026
1f25c92
Use __ for rule variables to avoid clashes
lucic71 Jul 7, 2026
72decbd
Add safe cstring rules
lucic71 Jul 10, 2026
6355eac
Update tests
lucic71 Jul 13, 2026
2c81e6f
Merge branch 'master' into safe-cstring
lucic71 Jul 14, 2026
044dc9c
Update tests
lucic71 Jul 14, 2026
60cddf0
Optimize rules
lucic71 Jul 14, 2026
0d6c0f3
Drop unsafe from refcount rule
lucic71 Jul 15, 2026
0e84766
Use CStringIterator where possible
lucic71 Jul 15, 2026
a011ca3
Add memmove semantics to Ptr::memcpy
lucic71 Jul 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions cpp2rust/converter/models/converter_refcount.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1169,6 +1169,9 @@ bool ConverterRefCount::VisitImplicitCastExpr(clang::ImplicitCastExpr *expr) {

if (expr->getCastKind() == clang::CastKind::CK_BitCast) {
if (expr->getType()->isVoidPointerType()) {
if (sub_expr->getType()->isVoidPointerType()) {
return Convert(sub_expr);
}
PushConversionKind push(*this, ConversionKind::Unboxed);
if (sub_expr->getType()->isPointerType() &&
sub_expr->getType()->getPointeeType()->isArrayType()) {
Expand Down
10 changes: 10 additions & 0 deletions libcc2rs/src/rc.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -952,6 +952,16 @@ thread_local! {
impl Ptr<u8> {
#[allow(clippy::explicit_counter_loop)]
pub fn memcpy(&self, src: &Self, len: usize) {
if *self > *src {

@nunoplopes nunoplopes Jul 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uhm, can't we change the loop below to increment src and just iterate over o..len?

let mut dst = self.offset(len);
let mut s = src.offset(len);
for _ in 0..len {
dst -= 1;
s -= 1;
dst.write(s.read());
}
return;
}
let mut dst = self.clone();
let mut i: usize = 0;
for value in src {
Expand Down
4 changes: 2 additions & 2 deletions rule-preprocessor/src/semantic.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,10 +399,10 @@ impl<'a, 'tcx> AstVisitor<'a, 'tcx> {
rustc_hir::ExprKind::Lit(_)
| rustc_hir::ExprKind::Path(_)
| rustc_hir::ExprKind::Ret(None)
| rustc_hir::ExprKind::Break(_, _)
| rustc_hir::ExprKind::Break(_, None)
| rustc_hir::ExprKind::Continue(_) => {}

rustc_hir::ExprKind::Ret(Some(e)) => {
rustc_hir::ExprKind::Ret(Some(e)) | rustc_hir::ExprKind::Break(_, Some(e)) => {
self.visit_expr(e, Access::Read);
}

Expand Down
Loading
Loading