Pin ruff version and fix sporadic double unlink in tests - #287
Merged
Conversation
Contributor
Author
|
While fixing the ruff version I encountered another problem: C++/unsafe/refcount all work with the same file declared in tmp, for example To fix this, I moved all files from /tmp into the temporary build directory of each test, the second argument is cwd: - self.cpp_result = RunResult(*lit.util.executeCommand(str(self.cpp_bin)))
+ self.cpp_result = RunResult(
+ *lit.util.executeCommand(str(self.cpp_bin), str(self.tmp_dir))
+ ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ruff got suddenly updated and our python linting broke. Pin ruff to a fixed version so linting is stable.