Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unordered argument matching recovers panics while trying expectations, but an error-valued panic currently leaves a nil error and incorrectly selects that expectation. Matching then panics again instead of trying a later valid expectation. Non-string panic values can also panic in the recovery handler.
Convert recovered values to errors in both implementations, preserving their text. Extend the existing recovery test and cover public Exec/Query calls that encounter a type-mismatched matcher before the matching expectation.
Validation: five regression cases fail before the fix. Required root race/coverage tests and
go vet ./...pass; root race tests also pass with Go 1.18.10 and 1.27.1. The additional Go 1.27.1 all-package run times out inexamples/orders, reproduced in the same test on the unchanged base. Whole-repository formatting also reports the same 16 pre-existing files on both versions; the changed files are formatted.