Skip to content

fix(cross-chain): resolve TokenHome token links - #15

Merged
JOY (JOY) merged 3 commits into
mainfrom
codex/fix-cross-chain-token-link
Jul 29, 2026
Merged

fix(cross-chain): resolve TokenHome token links#15
JOY (JOY) merged 3 commits into
mainfrom
codex/fix-cross-chain-token-link

Conversation

@JOY

Copy link
Copy Markdown

Summary

  • resolve current-chain ICTT TokenHome addresses to the underlying ERC-20 token from the local transaction token transfers
  • fall back to the TokenHome address page while loading or when no safe match is available
  • limit token-transfer lookups to cross-chain transaction details to avoid N+1 requests in lists

Root cause

The interchain indexer exposes the ICTT token transferrer address in TokenInfo.address_hash. On DOS Chain, 0x68a29f1ea0d8c0eea2f5090d077fa9b843f8d994 is TokenHome, while the emitted WDOS ERC-20 token is 0x1111111111111111111111111111111111111111. The frontend previously treated TokenHome as an ERC-20 token route, which returned 404.

Validation

  • pnpm lint:tsc
  • ESLint on all changed files
  • CSpell on all changed files
  • vitest run src/shared/values/entity/resolveInterchainTokenAddress.spec.ts (4/4 passed)
  • git diff --check
  • independent code review approved after removing N+1 list requests
  • Playwright component test added for resolved and safe-fallback links; local component build passed, browser execution is delegated to CI because the matching Chromium installer stalled locally

@JOY

Copy link
Copy Markdown
Author

CI evidence for the final refactor (fbfb40725):

  • Code quality, TypeScript, ESLint, CSpell, unit tests, toolkit build, env validation, CodeQL, mobile Playwright, and dark-mode Playwright passed.
  • The default Playwright project ran 32 tests. The two new TokenValueInterchain tests were included and were not listed among failed, flaky, or skipped tests.
  • The six failures are the same pre-existing Address/Home timeouts reproduced on earlier attempts: two in Address.pw.tsx and four in Home.pw.tsx.
  • The two cross-chain screenshot cases were flaky but passed on retry.
  • An independent final review approved the isolated feature wrapper with no must-fix findings.

The WDOS fix is therefore covered, while the remaining default-project failure is unrelated to this PR's runtime behavior.

@JOY
JOY (JOY) merged commit dff6f48 into main Jul 29, 2026
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant