Skip to content

chore: refresh store codegen snapshot - #5

Merged
JOY (JOY) merged 1 commit into
devfrom
codex/store-codegen-drift-fix
Jul 30, 2026
Merged

chore: refresh store codegen snapshot#5
JOY (JOY) merged 1 commit into
devfrom
codex/store-codegen-drift-fix

Conversation

@JOY

Copy link
Copy Markdown
Collaborator

What it solves

Resolves the scheduled Store Codegen Drift failure from https://github.com/DOS/Safe-Wallet/actions/runs/30521140143.

The staging CGW schema added OIDC authenticator enrollment support, while the committed Store schema and generated RTK Query client remained stale. The workflow also attempted to create a GitHub issue even though Issues are disabled for this repository.

How this PR fixes it

  • Regenerates the staging Store schema, schema hash, and auth client.
  • Adds the enroll authorization parameter and MFA authenticator query types and hooks.
  • Writes drift details to the GitHub Actions job summary.
  • Calls the Issues API only when ENABLE_DRIFT_ISSUES is explicitly enabled.

How to test it

yarn workspace @safe-global/store build:dev
yarn workspace @safe-global/store type-check
yarn workspace @safe-global/store lint
yarn workspace @safe-global/store prettier
yarn workspace @safe-global/store test --runInBand

Local results:

  • Store type-check passed.
  • Store lint passed.
  • Store Prettier check passed.
  • Store tests passed: 7 suites and 75 tests.
  • yarn verify:changed passed but reported no eligible changed web files.
  • Pre-push monorepo lint passed all 7 executed tasks with 20 pre-existing web warnings.

Affected flows

  • Scheduled Store codegen drift detection against the staging CGW schema.
  • Generated OIDC authorization arguments and authenticator query hooks for shared Store consumers.

Blast radius

  • packages/store is shared by web and mobile.
  • No existing endpoint was removed or renamed.
  • The generated auth module only gains optional arguments, new response types, and new hooks.
  • Drift detection still fails on generated differences; reporting now always uses the job summary and optionally uses Issues behind a repository variable.
  • No persistence, cache migration, route, layout, or analytics behavior changes.

Risks / not checked

  • Full web and mobile unit suites were started locally but produced no output for more than 10 minutes on the Windows host, so that run was stopped and is inconclusive.
  • MFA staging behavior was not exercised manually because this PR only synchronizes generated client code with the source schema.
  • Linux CI remains the source of truth for cross-platform validation.

Visual summary

flowchart LR
  A[Staging CGW OpenAPI schema] --> B[Store build dev]
  B --> C[Committed schema]
  B --> D[Generated auth client]
  B --> E[Schema hash]
  C --> F{Git diff clean}
  D --> F
  E --> F
  F -->|Yes| G[Workflow passes]
  F -->|No| H[Workflow fails]
  H --> I[GitHub Actions job summary]
  H --> J[Issues API only when enabled]
Loading

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻
  • I've listed affected flows and blast radius, and named what I did not verify 🎯

CLA signature

With the submission of this Pull Request, I confirm that I have read and agree to the terms of the Contributor License Agreement.

@JOY
JOY (JOY) force-pushed the codex/store-codegen-drift-fix branch from 6c9f080 to c34ae6f Compare July 30, 2026 08:48
@JOY
JOY (JOY) merged commit 8050b66 into dev Jul 30, 2026
8 checks passed
@JOY
JOY (JOY) deleted the codex/store-codegen-drift-fix branch July 30, 2026 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant