Skip to content

New menu entries for creating sub-objects on community and collection pages#5873

Draft
EikLoe wants to merge 8 commits into
DSpace:mainfrom
dspace-unimr:feature/ds-5825-add-sub-obj-button
Draft

New menu entries for creating sub-objects on community and collection pages#5873
EikLoe wants to merge 8 commits into
DSpace:mainfrom
dspace-unimr:feature/ds-5825-add-sub-obj-button

Conversation

@EikLoe

@EikLoe EikLoe commented Jun 26, 2026

Copy link
Copy Markdown
Member

References

Add references/links to any related issues or PRs. These may include:

Description

This PR adds new entries to the dso-edit menus on community and collection pages. Those entries allow you to directly add sub-objects such as communities or collections to an existing community or submit a new item in a collection.
In addition a new Submit item button will be added to the collection page, if collection.showSubmitButton is set to true.
If you're a logged in as a submitter and your frontend is configured to show the submit button the collection page should look like this:
Submit_Item_Button

If collection.showSubmitButton is set to false, the Submit item functionality is hidden in the dso-edit menu of the collection page:
Submit_Item_Menu

Instructions for Reviewers

Please add a more detailed description of the changes made by your PR. At a minimum, providing a bulleted list of changes in your PR is helpful to reviewers.

List of changes in this PR:

  • Added new AddSubObjectsMenuProvider in order to allow directly adding subcollections or subcommunities to an existing community
  • Added new SubmitNewItemMenuProvider to allow directly submitting items via the dso-edit menu on collection pages.
  • Created a new configuration entry for showing a submit button on collection pages
  • Added the new submit button on collection pages
  • Created and updated spec and e2e tests.

Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.

  1. Login as a community administrator and navigate to the community where you have admin privileges to.
  2. Make sure, you see the new Add community and Add collection entries in the dso-edit menu and test their functionality
  3. Navigate to a collection where you have at least submitter privileges: make sure you can see the new Add item entry in the dso-edit menu.
  4. Add the following configuration to your config.yml and rebuild your frontend:
collection:
  showSubmitButton: true
  1. Navigate to a collection where you have at least submitter privileges: make sure, the new Submit item button appears on the collection page. The menu entry should not be visible any more.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@EikLoe EikLoe added needs documentation PR is missing documentation. All new features and config changes require documentation. usability new feature component: Community Community display or editing component: Collection Collection display or editing labels Jun 26, 2026
@EikLoe

EikLoe commented Jun 26, 2026

Copy link
Copy Markdown
Member Author

I'm still not sure, whether we want the Submit button to display the text "Submit Publication" or "Submit JournalIssue" on collections with the specific entity types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: Collection Collection display or editing component: Community Community display or editing needs documentation PR is missing documentation. All new features and config changes require documentation. new feature usability

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New "Add sub-objects entry" in edit-menus on community or collection pages

1 participant