Skip to content

Some Yokai improvements for macOS#1984

Merged
illwieckz merged 2 commits into
masterfrom
illwieckz/yokai
Jun 25, 2026
Merged

Some Yokai improvements for macOS#1984
illwieckz merged 2 commits into
masterfrom
illwieckz/yokai

Conversation

@illwieckz

@illwieckz illwieckz commented Jun 22, 2026

Copy link
Copy Markdown
Member

Some Yokai improvements for macOS.

@illwieckz illwieckz added T-Improvement Improvement for an existing feature A-Build labels Jun 22, 2026
@slipher

slipher commented Jun 23, 2026

Copy link
Copy Markdown
Member

LGTM

The detection script might be a good thing to write in Python so that it could be used on Windows. But then I recall something about how for MSVC it doesn't actually run the detection builds, so maybe that would be more confusing than helpful.

@illwieckz

Copy link
Copy Markdown
Member Author

LGTM

Thanks.

The detection script might be a good thing to write in Python so that it could be used on Windows. But then I recall something about how for MSVC it doesn't actually run the detection builds, so maybe that would be more confusing than helpful.

The detection bash script isn't used by CMake, it's just a debug tool meant to not require CMake to verify that data is properly extracted from compiler internal and properly formatted in compiler output. So yes, everything not detected by compiling files isn't tested by the bash script.

@illwieckz illwieckz merged commit d473be3 into master Jun 25, 2026
10 checks passed
@illwieckz illwieckz deleted the illwieckz/yokai branch June 25, 2026 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Build T-Improvement Improvement for an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants