Fix Procfile parsing when there is no space after the colon - #220
Open
vulragrag-star wants to merge 1 commit into
Open
vulragrag-star wants to merge 1 commit into
vulragrag-star wants to merge 1 commit into
Conversation
Foreman-style entries like `web:rails s` previously failed the `^\w+:\s+` regex and surfaced as "No entries were found in Procfile". Allow zero-or-more whitespace after the colon and cover it with a unit test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Procfile lines without a space after the colon (e.g.
web:rails s) were ignored by the parser regex (:\s+), so Overmind reportedNo entries were found in Procfile. Allow zero-or-more whitespace after the colon so those entries load the same way asweb: rails s.Fixes #217
Test plan
go test ./start/ -run TestParseProcfileAllowsMissingSpaceAfterColonweb:echo histarts without the empty-Procfile error