[SVLS-9625] chore(ci): trigger a rebuild and re-sign of the CI image - #1322
Open
lym953 wants to merge 2 commits into
Open
[SVLS-9625] chore(ci): trigger a rebuild and re-sign of the CI image#1322lym953 wants to merge 2 commits into
lym953 wants to merge 2 commits into
Conversation
|
The ci image job only runs when a main push changes .gitlab/Dockerfile. Removing the trailing blank lines is a no-op change that makes that rule match, so the image is rebuilt, signed with ddsign, and pushed as :latest.
lym953
changed the title
lym953
changed the title
lym953
marked this pull request as ready for review
August 11, 2026 01:56
Contributor
There was a problem hiding this comment.
Pull request overview
This PR triggers a rebuild and re-sign of the registry.ddbuild.io/ci/datadog-lambda-extension:latest CI image by making a no-op change to .gitlab/Dockerfile, ensuring the ci image job runs on merge and produces a signed image compatible with image-integrity enforcement.
Changes:
- Removed trailing blank lines from
.gitlab/Dockerfileto force the CI image build rule to match. - No functional changes to the Docker build steps; change is intended solely to retrigger the pipeline behavior.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CI jobs are failing to start because
registry.ddbuild.io/ci/datadog-lambda-extension:latestis unsigned and image-integrity enforcement blocks the pull:ddsignsigning was added to theci imagejob in #1065 (2026-03-05), but the job only runs when a push tomainchanges.gitlab/Dockerfile— and the last such change was 2025-12-03. So the job has never run with signing enabled.This PR
Deletes the trailing blank lines from
.gitlab/Dockerfile: a no-op for the image content, but enough to make that rule match on merge and rebuild, sign, and push:latest.Testing
Ran the
ci imagejob against a throwaway tag to confirm signing works before relying on it (job 1939023452): the build pushed, andddsign signreported"signatureIsNew": true. SoDDSIGN_ID_TOKENand the signer allowlist are set up correctly — the job simply never ran.The merge itself can't be rehearsed from a branch. After merge, confirm the
ci imagejob ran and thatintegration-suite: [oom]/[lmi-oom]start cleanly.Resources
Slack discussion: https://dd.slack.com/archives/C027P1CK07N/p1785767085015909
🤖 Generated with Claude Code