Skip to content

Remove AgentTracer.noopScope() sentinel - #12060

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
mcculls/cleanup-noop-scope
Jul 27, 2026
Merged

Remove AgentTracer.noopScope() sentinel#12060
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
mcculls/cleanup-noop-scope

Conversation

@mcculls

@mcculls mcculls commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Motivation

This helps with switching between the two context manager approaches, since the checks now don't assume a particular implementation.

Additional Notes

To be merged in once #12008 is merged

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@mcculls
mcculls requested review from a team as code owners July 23, 2026 17:08
@mcculls mcculls added the comp: core Tracer core label Jul 23, 2026
@mcculls
mcculls requested review from mhlidd and removed request for a team July 23, 2026 17:08
@mcculls mcculls added tag: no release notes Changes to exclude from release notes type: refactoring labels Jul 23, 2026
@dd-octo-sts dd-octo-sts Bot added the tag: ai generated Largely based on code generated by an AI or LLM label Jul 23, 2026
@mcculls
mcculls requested a review from PerfectSlayer July 23, 2026 17:09

@datadog-official datadog-official Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: WARN

Removing the exported AgentTracer.noopScope() method is source- and binary-incompatible for custom instrumentations compiled against the current bootstrap API: an upgraded agent can throw NoSuchMethodError when that instrumentation loads or calls the method. The replacement public NoopScope singleton requires downstream recompilation and does not preserve existing callers.

Open Bits AI session

🤖 Datadog Autotest · Commit 5ba19ea · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5ba19eaaf2

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@mhlidd mhlidd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@datadog-official

datadog-official Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

🎯 Code Coverage (details)
Patch Coverage: 33.33%
Overall Coverage: 57.14% (-0.45%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: f09eb71 | Docs | Datadog PR Page | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.86 s 14.55 s [+1.4%; +2.9%] (significantly worse)
startup:insecure-bank:tracing:Agent 13.60 s 13.68 s [-1.2%; +0.2%] (no difference)
startup:petclinic:appsec:Agent 16.91 s 16.78 s [-0.2%; +1.7%] (no difference)
startup:petclinic:iast:Agent 16.86 s 16.95 s [-1.4%; +0.3%] (no difference)
startup:petclinic:profiling:Agent 16.06 s 16.80 s [-8.4%; -0.4%] (maybe better)
startup:petclinic:sca:Agent 16.90 s 16.85 s [-0.5%; +1.1%] (no difference)
startup:petclinic:tracing:Agent 16.05 s 16.10 s [-1.1%; +0.5%] (no difference)

Commit: f09eb71b · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

Base automatically changed from mcculls/cleanup-redis-advice to master July 27, 2026 19:32
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot requested a review from a team as a code owner July 27, 2026 19:32
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot requested review from vandonr and removed request for a team July 27, 2026 19:32
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@mcculls
mcculls force-pushed the mcculls/cleanup-noop-scope branch from 5ba19ea to f09eb71 Compare July 27, 2026 20:13
@mcculls
mcculls added this pull request to the merge queue Jul 27, 2026
@dd-octo-sts

dd-octo-sts Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Jul 27, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-07-27 21:41:11 UTC ℹ️ Start processing command /merge


2026-07-27 21:41:15 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).


2026-07-27 23:15:18 UTC ℹ️ MergeQueue: This merge request was merged

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 27, 2026
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 521ee6a into master Jul 27, 2026
781 of 783 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the mcculls/cleanup-noop-scope branch July 27, 2026 23:15
@github-actions github-actions Bot added this to the 1.65.0 milestone Jul 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: core Tracer core tag: ai generated Largely based on code generated by an AI or LLM tag: no release notes Changes to exclude from release notes type: refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants